Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unsupported directory substrings . and .. #2001

Open
wants to merge 97 commits into
base: gargnitin/fix-unsupported-directory-list/add-e2e-tests
Choose a base branch
from

Conversation

gargnitingoogle
Copy link
Collaborator

@gargnitingoogle gargnitingoogle commented Jun 11, 2024

Description

This is an addition on top of #1876 . This adds ., .., ./, ../, /./ and /../ to the list of unsupport object names (or substrings) in Cloud Storage Fuse.

Link to the issue in case of a bug fix.

NA

Testing details

  1. Manual - Yes
  2. Unit tests - Added new tests accordingly. All tests passed locally.
  3. Integration tests - Tested through presubmit.

@gargnitingoogle gargnitingoogle changed the base branch from master to gargnitin/fix-empty-directory-list-issue June 11, 2024 11:15
Copy link

codecov bot commented Jun 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.65%. Comparing base (077bb7f) to head (7aa8ad9).

Additional details and impacted files
@@                                    Coverage Diff                                     @@
##           gargnitin/fix-unsupported-directory-list/add-e2e-tests    #2001      +/-   ##
==========================================================================================
+ Coverage                                                   71.56%   71.65%   +0.09%     
==========================================================================================
  Files                                                          99       99              
  Lines                                                       10795    10795              
==========================================================================================
+ Hits                                                         7725     7735      +10     
+ Misses                                                       2724     2716       -8     
+ Partials                                                      346      344       -2     
Flag Coverage Δ
unittests 71.65% <ø> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gargnitingoogle gargnitingoogle added the execute-integration-tests Run only integration tests label Jun 11, 2024
@gargnitingoogle gargnitingoogle force-pushed the gargnitin/fix-empty-directory-list-issue branch from 88666fb to 358c310 Compare June 11, 2024 16:15
@gargnitingoogle gargnitingoogle force-pushed the gargnitin/fix-unsupported-directory-list/v2 branch 2 times, most recently from e2780a3 to 08ada82 Compare June 11, 2024 18:47
@gargnitingoogle gargnitingoogle force-pushed the gargnitin/fix-empty-directory-list-issue branch from 30d2284 to 79a92d8 Compare June 13, 2024 04:56
@gargnitingoogle gargnitingoogle force-pushed the gargnitin/fix-unsupported-directory-list/v2 branch from 08ada82 to d316e19 Compare June 13, 2024 05:24
@gargnitingoogle gargnitingoogle force-pushed the gargnitin/fix-empty-directory-list-issue branch from 86f0b31 to caa5342 Compare June 13, 2024 08:17
@gargnitingoogle gargnitingoogle force-pushed the gargnitin/fix-unsupported-directory-list/v2 branch from d316e19 to 563e837 Compare June 13, 2024 08:46
@gargnitingoogle gargnitingoogle force-pushed the gargnitin/fix-empty-directory-list-issue branch from 35b0c92 to 2860e0a Compare June 13, 2024 19:50
@gargnitingoogle gargnitingoogle force-pushed the gargnitin/fix-unsupported-directory-list/v2 branch from 563e837 to 85a6457 Compare June 13, 2024 20:10
@gargnitingoogle gargnitingoogle marked this pull request as ready for review June 14, 2024 02:55
@gargnitingoogle gargnitingoogle requested a review from a team as a code owner June 14, 2024 02:55
@gargnitingoogle gargnitingoogle requested review from sethiay and removed request for a team June 14, 2024 02:55
@gargnitingoogle gargnitingoogle changed the base branch from gargnitin/fix-empty-directory-list-issue to master June 14, 2024 02:58
@gargnitingoogle gargnitingoogle force-pushed the gargnitin/fix-unsupported-directory-list/v2 branch from 85a6457 to c0e4346 Compare June 15, 2024 19:53
@gargnitingoogle gargnitingoogle changed the base branch from master to gargnitin/fix-unsupported-directory-list/add-e2e-tests June 15, 2024 20:01
@gargnitingoogle gargnitingoogle force-pushed the gargnitin/fix-unsupported-directory-list/add-e2e-tests branch from b14e370 to 91b6052 Compare June 16, 2024 07:39
@gargnitingoogle gargnitingoogle force-pushed the gargnitin/fix-unsupported-directory-list/v2 branch from 8b64269 to bed6169 Compare June 16, 2024 07:40
@gargnitingoogle gargnitingoogle force-pushed the gargnitin/fix-unsupported-directory-list/add-e2e-tests branch from 91b6052 to 81066a6 Compare June 17, 2024 09:35
@gargnitingoogle gargnitingoogle force-pushed the gargnitin/fix-unsupported-directory-list/v2 branch from bed6169 to 0c20bee Compare June 17, 2024 09:53
@gargnitingoogle gargnitingoogle force-pushed the gargnitin/fix-unsupported-directory-list/add-e2e-tests branch from 81066a6 to 2fa3620 Compare June 17, 2024 10:06
@gargnitingoogle gargnitingoogle force-pushed the gargnitin/fix-unsupported-directory-list/v2 branch from 0c20bee to bb33559 Compare June 17, 2024 10:14
@gargnitingoogle gargnitingoogle force-pushed the gargnitin/fix-unsupported-directory-list/add-e2e-tests branch from 2fa3620 to b08263e Compare June 17, 2024 10:20
@gargnitingoogle gargnitingoogle force-pushed the gargnitin/fix-unsupported-directory-list/v2 branch from bb33559 to e2b7e1e Compare June 17, 2024 10:20
@gargnitingoogle gargnitingoogle force-pushed the gargnitin/fix-unsupported-directory-list/add-e2e-tests branch from b08263e to ffc20db Compare June 17, 2024 10:32
@gargnitingoogle gargnitingoogle force-pushed the gargnitin/fix-unsupported-directory-list/v2 branch from e2b7e1e to 832fd78 Compare June 17, 2024 10:35
@gargnitingoogle gargnitingoogle force-pushed the gargnitin/fix-unsupported-directory-list/add-e2e-tests branch 12 times, most recently from d2c4305 to 2145824 Compare October 14, 2024 03:19
@gargnitingoogle gargnitingoogle force-pushed the gargnitin/fix-unsupported-directory-list/add-e2e-tests branch 5 times, most recently from e9bf58c to 3a102d9 Compare October 15, 2024 11:28
@gargnitingoogle gargnitingoogle force-pushed the gargnitin/fix-unsupported-directory-list/add-e2e-tests branch 3 times, most recently from 9d023ae to a4a50b8 Compare October 22, 2024 11:31
@gargnitingoogle gargnitingoogle force-pushed the gargnitin/fix-unsupported-directory-list/add-e2e-tests branch 10 times, most recently from 47c754d to d6f61d5 Compare November 12, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
execute-integration-tests Run only integration tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant