Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[testing-on-gke part 2.1] Add top-level script to run tests #2272

Merged

Conversation

gargnitingoogle
Copy link
Collaborator

@gargnitingoogle gargnitingoogle commented Aug 2, 2024

Description

This adds on top of This adds on top of #2247, #2284, #2264, #2268, #2270, and #2271 .

This is followed up in #2359.

Link to the issue in case of a bug fix.

NA

Testing details

  1. Manual - NA
  2. Unit tests - NA
  3. Integration tests - NA

@gargnitingoogle gargnitingoogle changed the base branch from master to garnitin/add-gke-load-testing/add-new-code/v4 August 2, 2024 13:07
Copy link

codecov bot commented Aug 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.07%. Comparing base (552a917) to head (8b97e1c).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2272      +/-   ##
==========================================
+ Coverage   79.04%   79.07%   +0.03%     
==========================================
  Files         105      105              
  Lines       11577    11577              
==========================================
+ Hits         9151     9155       +4     
+ Misses       1961     1958       -3     
+ Partials      465      464       -1     
Flag Coverage Δ
unittests 79.07% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/add-run-script/v1 branch from 72e10d7 to d9b788b Compare August 5, 2024 09:02
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/add-new-code/v4 branch from 463063a to d5c20fe Compare August 5, 2024 12:37
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/add-run-script/v1 branch 2 times, most recently from 874d265 to 22166f7 Compare August 6, 2024 05:06
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/add-new-code/v4 branch from af76168 to c15e128 Compare August 6, 2024 08:45
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/add-run-script/v1 branch from 22166f7 to 5bf1782 Compare August 6, 2024 08:46
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/add-new-code/v4 branch from c15e128 to 2bf0680 Compare August 6, 2024 09:00
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/add-run-script/v1 branch from 5bf1782 to c58cdeb Compare August 6, 2024 09:00
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/add-new-code/v4 branch from 2bf0680 to f212f2c Compare August 6, 2024 09:05
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/add-run-script/v1 branch from c58cdeb to 71e6200 Compare August 6, 2024 09:05
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/add-new-code/v4 branch from f212f2c to c42795c Compare August 6, 2024 10:30
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/add-run-script/v1 branch from 71e6200 to f14ddfb Compare August 6, 2024 10:30
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/add-new-code/v4 branch from c42795c to 4b9745d Compare August 7, 2024 14:14
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/add-run-script/v1 branch from f14ddfb to 421868f Compare August 7, 2024 14:16
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/add-new-code/v4 branch from 4b9745d to ed5034e Compare August 7, 2024 15:56
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/add-run-script/v1 branch from 421868f to 0c223c0 Compare August 7, 2024 15:59
@gargnitingoogle gargnitingoogle changed the title [testing-on-gke part 5] Add top-level script to run tests [testing-on-gke part 2.1] Add top-level script to run tests Aug 8, 2024
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/add-new-code/v4 branch 2 times, most recently from e4f0a79 to 7a05b8d Compare August 8, 2024 10:16
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/add-run-script/v1 branch from 0c223c0 to c0043cb Compare August 8, 2024 10:18
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/add-new-code/v4 branch from 7a05b8d to 2f1d31f Compare August 8, 2024 13:14
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/add-run-script/v1 branch from c0043cb to 587942f Compare August 8, 2024 13:16
Copy link
Collaborator Author

@gargnitingoogle gargnitingoogle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some self-comments

@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/add-new-code/v4 branch from 2f1d31f to 01b2a11 Compare August 8, 2024 15:39
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/add-new-code/v4 branch from 741a69b to ea052f3 Compare August 20, 2024 05:14
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/add-run-script/v1 branch from 14d311e to 87babfb Compare August 20, 2024 05:23
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/add-new-code/v4 branch from ea052f3 to 14e8803 Compare August 20, 2024 05:25
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/add-run-script/v1 branch from 87babfb to 4d3d298 Compare August 20, 2024 05:36
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/add-new-code/v4 branch from 14e8803 to 6f52f00 Compare August 21, 2024 07:35
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/add-run-script/v1 branch 2 times, most recently from 25d6251 to 54fd63e Compare August 21, 2024 11:52
@gargnitingoogle gargnitingoogle changed the base branch from garnitin/add-gke-load-testing/add-new-code/v4 to master August 21, 2024 11:55
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/add-run-script/v1 branch from 54fd63e to 8b97e1c Compare August 22, 2024 10:23
@gargnitingoogle gargnitingoogle merged commit 2766ac4 into master Aug 22, 2024
10 checks passed
kislaykishore pushed a commit that referenced this pull request Aug 22, 2024
* Add run script

* minor fix in script

* pass workload-config and project-number in parsers

* fix workloads file path in run-script

* format run-script

* address some self-comments

* address some self-review comments

* address some self-review comments

* address some review comments

* address some self-review comments

* address self-review comments

* address review comments

* add license to script

* address a self-review comment

* install more dependencies in run-script
@gargnitingoogle gargnitingoogle removed their assignment Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants