Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make default value of enable-hns flag true #2377

Merged
merged 12 commits into from
Aug 23, 2024

Conversation

Tulsishah
Copy link
Collaborator

@Tulsishah Tulsishah commented Aug 21, 2024

Description

  • Make default value of enable-hns flag true.
  • Remove enableEmptyManagedFolder flag true with enableHNS flag true as it is changing flag value for flat bucket also.
  • Rename enableEmptyManagedFolder in dir.go with IncludeFoldersAsPrefixes.
  • Removed/Updated all the unit tests for changes.

Link to the issue in case of a bug fix.

NA

Testing details

  1. Manual - NA
  2. Unit tests - NA
  3. Integration tests - Automated

@Tulsishah Tulsishah added the execute-integration-tests Run only integration tests label Aug 21, 2024
Copy link

codecov bot commented Aug 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.07%. Comparing base (51abe5c) to head (1d6e535).
Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2377      +/-   ##
==========================================
+ Coverage   79.04%   79.07%   +0.03%     
==========================================
  Files         105      105              
  Lines       11577    11577              
==========================================
+ Hits         9151     9155       +4     
+ Misses       1961     1958       -3     
+ Partials      465      464       -1     
Flag Coverage Δ
unittests 79.07% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tulsishah Tulsishah changed the title Remove enableEmptyManagedFolder flag true with enableHNS flag true Make default value of enable-hns flag true Aug 21, 2024
@Tulsishah Tulsishah marked this pull request as ready for review August 22, 2024 05:13
@Tulsishah Tulsishah requested a review from a team as a code owner August 22, 2024 05:13
@kislaykishore kislaykishore requested a review from a team August 22, 2024 05:13
cfg/config.go Show resolved Hide resolved
@kislaykishore kislaykishore self-requested a review August 22, 2024 06:11
@Tulsishah Tulsishah removed the execute-integration-tests Run only integration tests label Aug 22, 2024
kislaykishore
kislaykishore previously approved these changes Aug 22, 2024
Copy link
Collaborator

@kislaykishore kislaykishore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving for config changes. Please get the business logic change reviewed from someone in the know.

@Tulsishah Tulsishah merged commit 4d5a56b into master Aug 23, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants