-
Notifications
You must be signed in to change notification settings - Fork 430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding gcs call log for storage layout api #2629
Open
anushka567
wants to merge
3
commits into
master
Choose a base branch
from
add-gcs-call-log-for-storage-api
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+5
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kislaykishore
requested review from
a team and
BrennaEpp
and removed request for
a team
October 25, 2024 06:46
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2629 +/- ##
==========================================
- Coverage 77.63% 77.50% -0.13%
==========================================
Files 109 110 +1
Lines 15540 15702 +162
==========================================
+ Hits 12064 12170 +106
- Misses 2964 3012 +48
- Partials 512 520 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Tulsishah
reviewed
Oct 25, 2024
anushka567
force-pushed
the
add-gcs-call-log-for-storage-api
branch
from
October 25, 2024 07:39
5d840e9
to
48341f0
Compare
anushka567
force-pushed
the
add-gcs-call-log-for-storage-api
branch
from
October 25, 2024 07:41
48341f0
to
3d2ab47
Compare
Tulsishah
previously approved these changes
Oct 25, 2024
anushka567
force-pushed
the
add-gcs-call-log-for-storage-api
branch
6 times, most recently
from
November 12, 2024 09:16
788738f
to
2a9b12f
Compare
gargnitingoogle
requested changes
Nov 12, 2024
anushka567
force-pushed
the
add-gcs-call-log-for-storage-api
branch
from
November 12, 2024 12:46
2a9b12f
to
e15b149
Compare
Tulsishah
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[Updated]
Since the logging information was incorrect in the previous implementation described below, now we only add a log (at info level) for actual getStorageLayout API call and report the time taken to serve the request.
[Previous implementation detail]
As part of HNS , storage layout API is called, logs for this does not come at TRACE severity unlike other GCS calls. Hence, added the logic for the same so that when log severity is set to TRACE, then storage layout api calls are also logged as gcs calls.
Any error faced during fetching the bucket type is already logged at error level, and will show up in the logs separately . However, as for the GCS call log, the storage layout api returns with status OK even when error is faced and logged immediately afterwards due to the nature of implementation.
For e.g:
Link to the issue in case of a bug fix.
NA
Testing details