Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coding guidelines for external contributions #2634

Merged
merged 5 commits into from
Nov 14, 2024
Merged

Conversation

ashmeenkaur
Copy link
Collaborator

Description

Added coding guidelines for external contributions.

Link to the issue in case of a bug fix.

NA

Testing details

  1. Manual - NA
  2. Unit tests - NA
  3. Integration tests - NA

@ashmeenkaur ashmeenkaur force-pushed the coding_guidelines branch 2 times, most recently from a145ccc to 4b260a1 Compare October 28, 2024 07:15
Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.53%. Comparing base (fdcacdb) to head (996a9a7).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2634      +/-   ##
==========================================
+ Coverage   77.43%   77.53%   +0.09%     
==========================================
  Files         110      110              
  Lines       15676    15698      +22     
==========================================
+ Hits        12139    12171      +32     
+ Misses       3016     3008       -8     
+ Partials      521      519       -2     
Flag Coverage Δ
unittests 77.53% <ø> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

docs/dev_guide.md Show resolved Hide resolved
docs/dev_guide.md Show resolved Hide resolved
@kislaykishore kislaykishore requested review from a team, kislaykishore and gargnitingoogle and removed request for a team and kislaykishore October 28, 2024 08:00
@ashmeenkaur ashmeenkaur marked this pull request as ready for review October 28, 2024 08:01
@ashmeenkaur ashmeenkaur requested a review from a team as a code owner October 28, 2024 08:01
@ashmeenkaur ashmeenkaur removed the request for review from gargnitingoogle October 28, 2024 08:01
docs/dev_guide.md Outdated Show resolved Hide resolved
docs/dev_guide.md Outdated Show resolved Hide resolved
docs/dev_guide.md Outdated Show resolved Hide resolved
Tulsishah
Tulsishah previously approved these changes Oct 28, 2024
docs/dev_guide.md Outdated Show resolved Hide resolved
docs/dev_guide.md Outdated Show resolved Hide resolved
docs/dev_guide.md Outdated Show resolved Hide resolved
docs/dev_guide.md Outdated Show resolved Hide resolved
docs/dev_guide.md Outdated Show resolved Hide resolved
docs/dev_guide.md Outdated Show resolved Hide resolved
docs/dev_guide.md Outdated Show resolved Hide resolved
docs/dev_guide.md Outdated Show resolved Hide resolved
docs/dev_guide.md Outdated Show resolved Hide resolved
docs/dev_guide.md Outdated Show resolved Hide resolved
Tulsishah
Tulsishah previously approved these changes Nov 12, 2024
Copy link
Collaborator

@charith87 charith87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as overall seems fine from my side.
Incremental changes can be done as separate PRs as necessary.

@ashmeenkaur ashmeenkaur merged commit d317ef9 into master Nov 14, 2024
13 checks passed
@ashmeenkaur ashmeenkaur deleted the coding_guidelines branch November 14, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants