-
Notifications
You must be signed in to change notification settings - Fork 430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Coding guidelines for external contributions #2634
Conversation
a145ccc
to
4b260a1
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2634 +/- ##
==========================================
+ Coverage 77.43% 77.53% +0.09%
==========================================
Files 110 110
Lines 15676 15698 +22
==========================================
+ Hits 12139 12171 +32
+ Misses 3016 3008 -8
+ Partials 521 519 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
57d4a40
to
6ce6616
Compare
6ce6616
to
afac008
Compare
afac008
to
996a9a7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving as overall seems fine from my side.
Incremental changes can be done as separate PRs as necessary.
Description
Added coding guidelines for external contributions.
Link to the issue in case of a bug fix.
NA
Testing details