-
Notifications
You must be signed in to change notification settings - Fork 430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate UploadHandler in BufferedWriteHandler struct #2670
Open
ashmeenkaur
wants to merge
4
commits into
uploadHandler
Choose a base branch
from
buffered_write_handler_changes
base: uploadHandler
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashmeenkaur
force-pushed
the
buffered_write_handler_changes
branch
2 times, most recently
from
November 11, 2024 06:05
a251009
to
84c159d
Compare
ashmeenkaur
force-pushed
the
buffered_write_handler_changes
branch
from
November 11, 2024 06:46
84c159d
to
2508f45
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## uploadHandler #2670 +/- ##
=================================================
+ Coverage 77.55% 77.58% +0.02%
=================================================
Files 112 112
Lines 15797 15803 +6
=================================================
+ Hits 12252 12261 +9
+ Misses 3022 3019 -3
Partials 523 523
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
vadlakondaswetha
approved these changes
Nov 11, 2024
ashmeenkaur
force-pushed
the
uploadHandler
branch
2 times, most recently
from
November 13, 2024 06:54
e5945ac
to
039429f
Compare
ashmeenkaur
force-pushed
the
buffered_write_handler_changes
branch
from
November 13, 2024 09:45
2508f45
to
81dc80c
Compare
ashmeenkaur
force-pushed
the
buffered_write_handler_changes
branch
from
November 13, 2024 09:45
81dc80c
to
fa29ea7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR integrates the
UploadHandler
into theBufferedWriteHandler
to enable efficient and synchronized uploads of filled blocks to GCS.Key changes
BufferedWriteHandler
is complete, it's automatically sent to theUploadHandler
for asynchronous uploading.Flush
method is added toBufferedWriteHandler
. This method ensures current block is sent for upload and then calls theFinalize
method on theUploadHandler
to finalize the GCS object.Link to the issue in case of a bug fix.
NA
Testing details