Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: windows title bar theme switch #936

Merged
merged 4 commits into from
Feb 17, 2025
Merged

Conversation

crazy-zxx
Copy link
Contributor

修复在Windows系统下切换明暗模式时,标题栏颜色没有切换的问题。
Fix the problem that the title bar color does not switch when switching between light and dark modes under Windows.

for issue : #838

修复系统切换明暗模式时,标题栏颜色没有切换的问题。
Repair the problem that the title bar color does not switch when the system switches between light and dark modes.
@crazy-zxx crazy-zxx requested a review from monkeyWie as a code owner February 16, 2025 16:00
@monkeyWie monkeyWie added the bug Something isn't working label Feb 17, 2025
@monkeyWie monkeyWie linked an issue Feb 17, 2025 that may be closed by this pull request
Copy link

codecov bot commented Feb 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.91%. Comparing base (69bb875) to head (819078d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #936      +/-   ##
==========================================
+ Coverage   59.69%   59.91%   +0.22%     
==========================================
  Files          36       36              
  Lines        4538     4538              
==========================================
+ Hits         2709     2719      +10     
+ Misses       1555     1543      -12     
- Partials      274      276       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

修复窗口标题栏颜色不跟随系统主题的bug。如果在亮色主题下手动切换暗色主题仍有问题,待修复。。。
@crazy-zxx crazy-zxx requested a review from monkeyWie February 17, 2025 10:33
@monkeyWie monkeyWie changed the title Update app_view.dart fix: windows title bar theme switch Feb 17, 2025
@monkeyWie monkeyWie merged commit a094715 into GopeedLab:main Feb 17, 2025
11 checks passed
@monkeyWie
Copy link
Member

.感谢!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

系统切换为深色模式时,标题栏颜色没有切换
2 participants