Testable initialization of Gu.Localizalization.Culture #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added test for getting invalid culture.
| { | ||
| get | ||
| { | ||
| return AllCultures.Select(x => TryGetRegion(x, out var region) ? region : null).Where(x => x != null).ToList(); |
There was a problem hiding this comment.
LINQ in the getter is potentially expensive here.
There was a problem hiding this comment.
It might be the first time at least. The RegionInfo is cached by Microsoft, so it might not be that bad. Are you up for profiling this?
| @@ -8,52 +8,18 @@ namespace Gu.Localization | |||
| /// <summary> Utility class for <see cref="CultureInfo"/> </summary> | |||
| internal static class Culture | |||
| { | |||
| internal static readonly IReadOnlyList<CultureInfo> AllCultures = | |||
| internal static IReadOnlyList<CultureInfo> AllCultures = | |||
There was a problem hiding this comment.
It's not necessary for functionality to be settable. But it makes testing TryGet possible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies the initialization of the internal class Gu.Localization.Culture. And by virtue of making AllCultures settable, the class is a little easier to test. It is also another solution to issue #82 .