TouchProcessInfo: use shell execute like .NET Framework's default #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default in .NET Framework and newer .NET (or .NET Core) changed. However, when "UseShellExecute" set to false (in newer .NET), starting the process fails immediately and stops the application
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default in .NET Framework and newer .NET (or .NET Core) changed. However, when "UseShellExecute" set to false (in newer .NET), starting the process fails immediately and stops the application.
This is enough for an application in .NET 8 to not crash when using a touchscreen with the property
touch:TextBox.ShowTouchKeyboardOnTouchEnter="True"set for a text box/NumericBox, on Windows 11 23H2.However, it is not enough for the functionality to work as before. After reading a bit, it seems that since at least some Windows 10 release, the current workarounds doesn't work anymore. You might want to take a look at https://github.com/AlexeiScherbakov/osklib or https://github.com/Seuleuzeuh/WPFTabTipMixedhardware that seemed to have a more complete handling of TabTip that doesn't open in recent versions of Win10 and Win11.
To avoid having future crashes in the future, and to have to create a custom build of this library with the Touch functionality removed like I had to, I would suggest having the namespace "Gu.Wpf.NumericInput.Touch" published as a separate nuget package.