-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
task3 available for review, but will be updated #11
Conversation
e182767
to
a07bc4c
Compare
Build output Deploying to stage task3 |
6124496
to
b985bf1
Compare
✔️ Create a lambda function called `getProductsList` of Product Service which will be triggered by the HTTP GET method. ✔️ The requested URL should be `/products`. ✔️ The response from the lambda should be a full array of products. ✔️ This endpoint should be integrated with Frontend app for Product List Page representation Additional tasks: ✔️ Async/await is used in lambda functions ✔️ ES6 modules are used for Product Service implementation ✔️ ESBuild is configured for Product Service. Extra effort: * api gateway is defined as separate service to reuse for all future lambdas * app is build on deploy stage with forked scriptable plugin * api gateway url is passed to frontend app build
✔️ Create a lambda function called `getProductsById` in Product Service which will be triggered by the HTTP GET method. ✔️ The requested URL should be `/products/{productId}` ✔️ The response from the lambda should be 1 searched product from an array of products (mock data should be used). Extra effort: * This endpoint is integrated with Frontend app. New route and components set is created * Business logic moved from handler code to a service class
bfc4609
to
c7702a7
Compare
This is a temporary Pull Request to start review process.
I'd like to better structure changes in commits with proper descriptions.
What is done:
api-gateway
andproducts-api
api-gateway
is made in separate service to make it possible serve all functions services from same gatewayproducts-api
implements 2 required functionsgetProductsList
andgetProductById
swagger.json
for generated api-gateway is downloaded using aws cli and published to frontend app/swagger
role to display Swagger UIgithub-actions
bot commentWhat was not done:
See also #3 for previous task implementation as may clarify some setup in the repo