Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

J# 48665 #3201

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Khalid-Shahin
Copy link
Contributor

EvidenceVariable with research study data dictionary elements added

EvidenceVariable with research study data dictionary elements added
Copy link
Contributor

@brynrhodes brynrhodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Several changes requested in the comments based on the resolved disposition in the ticket. Also, can we add some examples illustrating the use of the new elements?

<code value="CodeableConcept"/>
</type>
</element>
<element id="EvidenceVariable.datatype">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ticket indicates a dataStorage element should be added and that dataType and path should be sub-elements of dataStorage?

<type>
<code value="CodeableConcept"/>
</type>
</element>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ticket indicates classifier should have an Example binding?

<type>
<code value="CodeableConcept"/>
</type>
</element>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ticket indicates the dataStorage.dataType element should have a Preferred binding, but I don't see a binding?

<type>
<code value="CodeableConcept"/>
</type>
</element>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ticket indicates contraint.conditional should have an Example binding?

<type>
<code value="CodeableConcept"/>
</type>
</element>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ticket indicates code should have an Example binding

<type>
<code value="CodeableConcept"/>
</type>
</element>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ticket indicates missingDataMeaning should have an example value set?

<type>
<code value="CodeableConcept"/>
</type>
</element>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ticket indicates unacceptableDataHandling should have an example value set?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants