--wip-- [skip ci]

crates/control/src/game_controller_state_filter.rs

@@ -61,12 +61,25 @@ impl GameControllerStateFilter {
             &mut self.opponent_state,
             *context.is_referee_initial_pose_detected,
         );
+        /*
+        let filtered_penalties = context.player_role_mapping.iter.find_in_penalties_or_something.collect();
+        For each role in mapping find the corresponding player and assign that role the penalty of the player based on the game controller penalties
+
+        New node which filters player mappings based on the incoming messages
+
+        When coming in from penalized and not registered in config yet, make sure to register self by sending message
+
+        Allow giving none to role number in pepsi playernumber so substitutes can be deployed at same time as everyone else (explicit None?)
+
+        
+         */
         let filtered_game_controller_state = FilteredGameControllerState {
             game_state: game_states.own,
             opponent_game_state: game_states.opponent,
             game_phase: context.game_controller_state.game_phase,
             kicking_team: context.game_controller_state.kicking_team,
             penalties: context.game_controller_state.penalties,
+            //todo!filter penalties from playersnumbers to rolenumbers
             remaining_number_of_messages: context
                 .game_controller_state
                 .remaining_amount_of_messages,

crates/spl_network_messages/src/game_controller_state_message.rs

@@ -112,19 +112,13 @@ impl TryFrom<RoboCupGameControlData> for GameControllerStateMessage {
                 }
             })
             .collect();
-        if message.playersPerTeam > MAX_NUM_PLAYERS {
-            bail!(
-                "unexpected number of players per team. Expected: {MAX_NUM_PLAYERS}. Got: {}",
-                message.playersPerTeam
-            );
-        }
-        let hulks_players = (0..message.playersPerTeam)
+        let hulks_players = (0..MAX_NUM_PLAYERS)
             .map(|player_index| {
                 message.teams[hulks_team_index].players[player_index as usize].try_into()
             })
             .collect::<Result<Vec<_>>>()?;
         // todo!("Assign penalties to players not roles");
-        let opponent_players = (0..message.playersPerTeam)
+        let opponent_players = (0..MAX_NUM_PLAYERS)
             .map(|player_index| {
                 message.teams[opponent_team_index].players[player_index as usize].try_into()
             })