default opponent goalkeeper number when above 7 #1123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaikRe
force-pushed
the
in_der_schule_die_zahl_8_nie_gelernt_und_deswegen_is_aus_dir_nix_geworden
branch
from
02563b3 to
295f503
Compare
schmidma
approved these changes
Jul 10, 2024
MaikRe
deleted the
in_der_schule_die_zahl_8_nie_gelernt_und_deswegen_is_aus_dir_nix_geworden
branch
oleflb
pushed a commit
to oleflb/hulk
that referenced
this pull request
Jul 15, 2024
oleflb
pushed a commit
that referenced
this pull request
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why? What?
If the opponent uses a playernumber above 7 for the goalkeeper the message filter bails and we discard the message aka we don't receive any information from the game controller and don't go into the standby phase and cannot play at all!
This defaults it to
PlayerNumber::One.To the reviewer, the
Oneis sort of arbitrary, I could just dodefault()but either way that information is inaccurate.Let me know what you think.
Fixes #
ToDo / Known Issues
Ideas for Next Iterations (Not This PR)
#1021
How to Test
Use current main:
Before going into
standby, substitute the opponent goalkeeper with a number higher than 7.Then click standby button and observe that we don't do anything.
Also the error logs can be looked at.
Now use the new code and repeat the procedure and oh wow now it works.