A demo endpoint to support onboarding of new team members #156
Conversation
|
|
||
|
|
||
| @pytest.mark.live | ||
| def test_get_demo(): |
There was a problem hiding this comment.
I see the idea here. However I'm not so keen on unit tests that need external dependencies such as a live system to work. It potentially sets a bad precedent for future tests.
I also see the consequence of this test is that by default pyenv now needs -m 'not live' where as ideally testing live should be the exception.
I would prefer that you ripped out the live testing part and we figure out another way to do integration testing on the live or staging deployments.
@harryjmoss & @docsteveharris what are your thoughts on how strict with codebase we should be?
There was a problem hiding this comment.
Happy to remove this and circle back with an alternative
But what is your practice when you deploy?
We don't seem to have a testing step, and the it's not just the data that changes but because we have mock and live endpoints which have separate code then we do need a way of testing that code, and those tests can't run anywhere other than in the live environment.
There was a problem hiding this comment.
@jongillham I've removed the live pytest components so we can close this pull request 🤞. The pytest work is now on #162
docsteveharris
force-pushed
the
steve/sql-vignette
branch
from
5b7034d to
6f31d53
Compare
force pytest installation notes on debugging live from the GAE distinguish tests for the live environment filter live tests out of CI
docsteveharris
force-pushed
the
steve/sql-vignette
branch
from
6f31d53 to
be8ac8a
Compare
|
Closing as I'm trying to tidy the branches/pull requests so that I've not mixed work from several issues into one pull request. |
Simple demonstration of how to write both the API and the Plotly Dash web page.
I've accidentally wrapped up a typo fix to the hospital endpoint in this but otherwise all the changes are related to the demo endpoint or to the documentation. I also added a couple of notes on how to work with PyCharm since this was my first time trying this in anger.
@jongillham : the run configurations for PyCharm depend on a plugin that does the same job as your shell prefix. It means that you can develop and PyCharm automatically updates and re-runs both the api and the web application.
Documentation is sketchy and messy but hopefully better than nothing.