Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing in both live and mock environments #169

Closed
wants to merge 1 commit into from

Conversation

docsteveharris
Copy link
Contributor

see #161 (although this issue could be better named)

force pytest installation
notes on debugging live from the GAE
distinguish tests for the live environment
filter live tests out of CI

Note from @jongillham

I see the idea here. However I'm not so keen on unit tests that need external dependencies such as a live system to work. It potentially sets a bad precedent for future tests.

I also see the consequence of this test is that by default pyenv now needs -m 'not live' where as ideally testing live should be the exception.

I would prefer that you ripped out the live testing part and we figure out another way to do integration testing on the live or staging deployments.

@harryjmoss & @docsteveharris what are your thoughts on how strict with codebase we should be?

force pytest installation
notes on debugging live from the GAE
distinguish tests for the live environment
filter live tests out of CI
@docsteveharris docsteveharris deleted the steve/feature/161-better-pytest branch December 4, 2022 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant