Qa 2024 09 27 (#141)

* sudoken: v0.0.5

* sudoken: v0.0.6

* hc_seed_bundle: v0.1.4

* holochain: v0.1.0-rc

* version bump

* seed-bundle: holoport_key

* set code owners

* sudoken: 0.0.9

* fix: quick-start-status-code

* bump sodoken

* bump wasm-bindgen-cli

* use workspace.dependencies

* bump ed25519-dalek to 2.1.1

* update versions in Cargo.toml

* move to flake.nix

* update cargo deps

* wip: v3

* wip: v3

* fix tests

* added todos

* hpos-config: tests

* Interim commit with tests passing

* ui tweaks and v3 updates

* git ignore

* pass pubkeys as bytes

* fix error on multiple hps, ui tweaks, and re-enable memproof check

* design review changes

* pr feedback suggestions

* fix package-lock issue

* Added missing v3 implementation (#131)

* Added missing v3 implementation

* Added email getter on Config

* Minimally updated gen-cli to use Clap

---------

Co-authored-by: Matthew Geddes <[email protected]>
Co-authored-by: Matthew Geddes <[email protected]>
Co-authored-by: Joel Ulahanna <[email protected]>

* Added missing commit for host pub key (#134)

Co-authored-by: Matthew Geddes <[email protected]>

* feat: set up direnv, formatter and format flake (#133)

* configure direnv

* chore(nix): configure formatter and run `nix fmt`

* feat: add passphrase confirmation (#138)

* Added some basic logging (#139)

Co-authored-by: Matthew Geddes <[email protected]>

---------

Co-authored-by: zo-el <[email protected]>
Co-authored-by: Robbie Carlton <[email protected]>
Co-authored-by: Alastair Ong <[email protected]>
Co-authored-by: Zeeshan <[email protected]>
Co-authored-by: Matthew Geddes <[email protected]>
Co-authored-by: Patrick Winfield <[email protected]>
Co-authored-by: Patrick Winfield <[email protected]>
Co-authored-by: Alastair Ong <[email protected]>
Co-authored-by: Matthew Geddes <[email protected]>
Co-authored-by: Matthew Geddes <[email protected]>
Co-authored-by: Stefan Junker <[email protected]>
Co-authored-by: Mateusz Rybczonek <[email protected]>

Cargo.toml

@@ -21,3 +21,4 @@ structopt = "0.3.25"
 serde = { version = "1.0.123", features = ["derive"] }
 base64 = "0.13.0"
 failure = "0.1.5"
+log = "0.4.22"

gen-web/res/index.html

@@ -154,6 +154,12 @@ <h1 class="step-title">
           <input id="seed-passphrase" class="input" name="seed-passphrase" type="text"/>
         </div>
         <span id="seed-passphrase-error-message" class="error-red"></span>
+
+        <div id="confirm-passphrase-form-item" class="input-container confirm-passphrase">
+          <label id="confirm-passphrase-label" class="input-label" for="confirm-passphrase">Confirm Passphrase</label>
+          <input id="confirm-passphrase" class="input" name="confirm-passphrase" type="text"/>
+        </div>
+        <span id="confirm-passphrase-error-message" class="error-red"></span>
       </div>
 
 

gen-web/res/style.css

@@ -235,7 +235,9 @@ form > .input-container:not(:first-child) {
   margin-bottom: 10px;
 }
 
-
+.confirm-passphrase {
+  margin-top: 30px;
+}
 
 /* Image & Icon Elements */
 .holo-banner {
@@ -651,7 +653,7 @@ button {
   background-color: #ffffff;
   width: 151px;
   height: 42px;
-  box-sizing: border-box;  
+  box-sizing: border-box;
 }
 
 .action-button,

gen-web/src/index.js

@@ -50,6 +50,7 @@
   const inputs = {
     registrationCode: document.querySelector('#registration-code'),
     seedPassphrase: document.querySelector('#seed-passphrase'),
+    confirmPassphrase: document.querySelector('#confirm-passphrase'),
     email: document.querySelector('#email'),
     password: document.querySelector('#password'),
     passwordCheck: document.querySelector('#password-check'),
@@ -61,6 +62,7 @@
     emailInputArea: document.querySelector('#email-form-item'),
     registrationCodeInputArea: document.querySelector('#registration-code-form-item'),
     seedPassphraseInputArea: document.querySelector('#seed-passphrase-form-item'),
+    confirmPassphraseInputArea: document.querySelector('#confirm-passphrase-form-item'),
     emailReadOnly: document.querySelector('#email-read-only'),
     passwordInputArea: document.querySelector('#password-form-item'),
     passwordCheckInputArea: document.querySelector('#password-check-form-item'),
@@ -73,6 +75,7 @@
   const errorMessages = {
     missingFields: 'Please complete missing fields.',
     seedPassphrase: 'Your passphrase needs to be at least 20 characters in length',
+    confirmPassphrase: 'Passphrases do not match',
     registrationCode: 'Invalid code',
     email: 'Invalid email format',
     password: 'Your password needs to be at least 8 characters in length',
@@ -88,6 +91,7 @@
 
   // global variable used to pass seed passphrase between steps 2 and 3
   let seedPassphrase
+  let confirmPassphrase
 
   /** Actions executed at button click
   * ======================================
@@ -124,6 +128,7 @@
             return
           }
           seedPassphrase = inputs.seedPassphrase.value
+          confirmPassphrase = inputs.confirmPassphrase.value
 
           updateUiStep(3)
           updateProgressBar(2)
@@ -247,7 +252,7 @@
         buttons.genSeed.disabled = true
         buttons.genSeed.innerHTML = 'Saved Seed & Key Files'
         verifySeedDownloadComplete(downloadSeedTracker)
-      }, 2000)      
+      }, 2000)
     },
     download: async () => {
       /* Communicate visually that something is happening in the background */
@@ -414,12 +419,14 @@
   /* Bind input actions to inputArea actions */
   inlineVariables.registrationCodeInputArea.onclick = e => { inputs.registrationCode.focus(); return click.activateInput(e) }
   inlineVariables.seedPassphraseInputArea.onclick = e => { inputs.seedPassphrase.focus(); return click.activateInput(e) }
+  inlineVariables.confirmPassphraseInputArea.onclick = e => { inputs.confirmPassphrase.focus(); return click.activateInput(e) }
   inlineVariables.emailInputArea.onclick = e => { inputs.email.focus(); return click.activateInput(e) }
   inlineVariables.passwordInputArea.onclick = e => { inputs.password.focus(); return click.activateInput(e) }
   inlineVariables.passwordCheckInputArea.onclick = e => { inputs.passwordCheck.focus(); return click.activateInput(e) }
   /* Bind actions to inputs */
   inputs.registrationCode.onfocus = click.activateInput
   inputs.seedPassphrase.onfocus = click.activateInput
+  inputs.confirmPassphrase.onfocus = click.activateInput
   inputs.email.onfocus = click.activateInput
   inputs.password.onfocus = click.activateInput
   inputs.passwordCheck.onfocus = click.activateInput
@@ -683,6 +690,7 @@
   */
   const resetFields = (inputElements) => {
     inlineVariables.formErrorMessage.innerHTML = ''
+
     for (let inputElement of inputElements) {
       inputElement.classList.remove('error-red')
       document.querySelector(`#${inputElement.id}-error-message`).innerHTML = ''
@@ -766,14 +774,19 @@
     return valid
   }
   const confirmValidPassPhrase = () => {
-    const inputElements = Object.values({ seedPassphrase: inputs.seedPassphrase })
+    const inputElements = Object.values({ seedPassphrase: inputs.seedPassphrase, confirmPassphrase: inputs.confirmPassphrase })
     resetFields(inputElements)
+
     if (!inputs.seedPassphrase.value) {
       const missingFields = inputElements.filter(inputs => !inputs.value)
       renderInputError(errorMessages.missingFields, missingFields)
     } else if (!validatePassphrae(inputs.seedPassphrase.value)) {
       renderInputError(errorMessages.seedPassphrase, [inputs.seedPassphrase])
-    } else return true
+    } else if (inputs.seedPassphrase.value !== inputs.confirmPassphrase.value) {
+      renderInputError(errorMessages.confirmPassphrase, [inputs.confirmPassphrase])
+    } else {
+      return true
+    }
   }
 
 })()

seed-bundle-explorer/Cargo.toml

@@ -18,6 +18,7 @@ rmp-serde = "1.1.0"
 thiserror = "1.0"
 one_err = "0.0.8"
 base36 = "0.0.1"
+log = { workspace = true }
 
 [dev-dependencies]
 tokio = { workspace = true, features = [ "full" ] }

seed-bundle-explorer/src/lib.rs

@@ -1,6 +1,7 @@
 use ed25519_dalek::{ed25519, SigningKey, VerifyingKey};
 use hc_seed_bundle::*;
 use hpos_config_core::Config;
+use log::debug;
 
 /// get pub key for the device bundle in the config
 pub async fn holoport_public_key(
@@ -112,21 +113,27 @@ pub async fn unlock(
     device_bundle: &String,
     passphrase: Option<String>,
 ) -> SeedExplorerResult<SigningKey> {
+    debug!("Base64 decoding device bundle.");
     let cipher = base64::decode_config(device_bundle, base64::URL_SAFE_NO_PAD)?;
+    debug!("Matching device bundle cipher.");
     match UnlockedSeedBundle::from_locked(&cipher).await?.remove(0) {
         LockedSeedCipher::PwHash(cipher) => {
             let passphrase = passphrase
                 .as_ref()
                 .ok_or(SeedExplorerError::PasswordRequired)?;
+            debug!("PwHash cipher used and password present.");
             let passphrase = sodoken::BufRead::from(passphrase.as_bytes().to_vec());
+            debug!("Unlocking seed with passphrase.");
             let seed = cipher.unlock(passphrase).await?;
 
+            debug!("Casting seed to 32-byte slice.");
             let seed_bytes: [u8; 32] = match (&*seed.get_seed().read_lock())[0..32].try_into() {
                 Ok(b) => b,
                 Err(_) => {
+                    debug!("Seed not 32 bytes: {:?}", &seed.get_seed());
                     return Err(SeedExplorerError::Generic(
                         "Seed buffer is not 32 bytes long".into(),
-                    ))
+                    ));
                 }
             };