-
-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
workflows/dispatch-build-bottle: run prepare
job as root in container
#186800
workflows/dispatch-build-bottle: run prepare
job as root in container
#186800
Conversation
Hi, thanks for your contribution to Homebrew! You already have >=15 open pull requests, so please get them ready to be merged or close them before you open more. If CI fails on any of them, please fix it or ask for help doing so. |
Actually, that should actually work in Docker. Do we want that though? I'm not sure. |
Should be fine for the |
21683f7
to
e02a249
Compare
container
"prepare
job as root in container
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's ship this for now since this is blocking bottling.
@@ -50,6 +50,7 @@ jobs: | |||
runs-on: ubuntu-22.04 | |||
container: | |||
image: ghcr.io/homebrew/ubuntu22.04:master | |||
options: --user=root |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that the alternative to this is to sudo chown "${GITHUB_OUTPUT}"
, but I don't know how to translate that to JavaScript. 🥲
Hopefully someone else can tell us!
You don't need root if you move setup-homebrew to run first. It applies the necessary permission fixes to make everything work. |
This unfortunately didn't work due to permission issues: https://github.com/Homebrew/homebrew-core/actions/runs/10809935351/job/29986089580
A workaround could be to set
options: --user root
, butbrew ruby
will probably refuse to run as root.Reverts #186614