Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflows/autobump: set BrewTestBot as committer #197317

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

carlocab
Copy link
Member

We can do this by setting HOMEBREW_GIT_COMMITTER_NAME and
HOMEBREW_GIT_COMMITTER_EMAIL.

Needs Homebrew/brew#18749, but this doesn't do anything until then, so
it doesn't hurt to merge this early.

This makes sure that autobump commits don't show up as "Unverified" in
the GitHub UI.

We can do this by setting `HOMEBREW_GIT_COMMITTER_NAME` and
`HOMEBREW_GIT_COMMITTER_EMAIL`.

Needs Homebrew/brew#18749, but this doesn't do anything until then, so
it doesn't hurt to merge this early.

This makes sure that autobump commits don't show up as "Unverified" in
the GitHub UI.
@carlocab carlocab requested review from MikeMcQuaid and a team as code owners November 11, 2024 10:51
@carlocab carlocab added the CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. label Nov 11, 2024
@github-actions github-actions bot added workflows PR modifies GitHub Actions workflow files automerge-skip `brew pr-automerge` will skip this pull request labels Nov 11, 2024
@carlocab
Copy link
Member Author

Will fix the actionlint failure separately.

@carlocab carlocab added this pull request to the merge queue Nov 11, 2024
Merged via the queue into master with commit 6cbe312 Nov 11, 2024
18 of 19 checks passed
@carlocab carlocab deleted the autobump-committer-name-email branch November 11, 2024 11:06
@MikeMcQuaid
Copy link
Member

Thanks @carlocab!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge-skip `brew pr-automerge` will skip this pull request CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. workflows PR modifies GitHub Actions workflow files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants