Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

diary 0.15 (new formula) #204366

Merged
merged 2 commits into from
Jan 22, 2025
Merged

diary 0.15 (new formula) #204366

merged 2 commits into from
Jan 22, 2025

Conversation

in0rdr
Copy link
Contributor

@in0rdr in0rdr commented Jan 15, 2025

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Requesting to add latest diary v0.15. Thank you for review.

@github-actions github-actions bot added the new formula PR adds a new formula to Homebrew/homebrew-core label Jan 15, 2025
Copy link
Contributor

Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request.

@chenrui333 chenrui333 added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label Jan 16, 2025
@chenrui333 chenrui333 force-pushed the feat/diary-v0.15 branch 2 times, most recently from 543d7dc to d774f06 Compare January 16, 2025 02:04
@in0rdr
Copy link
Contributor Author

in0rdr commented Jan 16, 2025

Thank you for the improvements @chenrui333 much appreciated

Formula/d/diary.rb Outdated Show resolved Hide resolved
@github-actions github-actions bot added the autosquash Automatically squash pull request commits according to Homebrew style. label Jan 17, 2025
@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Jan 17, 2025
Copy link
Member

@nandahkrishna nandahkrishna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor comment for consistency with other livecheck blocks, but otherwise looks good to me – thanks!

Formula/d/diary.rb Outdated Show resolved Hide resolved
@github-actions github-actions bot added the autosquash Automatically squash pull request commits according to Homebrew style. label Jan 21, 2025
diary: consistency with other livecheck blocks
diary: fix brew style, tap syntax
diary: assert shell stderr output
diary: improve tests
diary: update deps and livecheck

Co-authored-by: Nanda H Krishna <[email protected]>
Signed-off-by: Rui Chen <[email protected]>
@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Jan 21, 2025
Copy link
Contributor

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Jan 22, 2025
@BrewTestBot BrewTestBot enabled auto-merge January 22, 2025 09:59
@BrewTestBot BrewTestBot added this pull request to the merge queue Jan 22, 2025
Merged via the queue into Homebrew:master with commit fe864c2 Jan 22, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. new formula PR adds a new formula to Homebrew/homebrew-core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants