Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

molten-vk: install ICD to non-overridable path #204611

Merged
merged 4 commits into from
Feb 10, 2025
Merged

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Jan 17, 2025

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Closes #203233.

May as well use non-overridable path to reduce chances of user configuration impacting functionality.

Prior bottle,

XDG_DATA_DIRS=/tmp vulkaninfo --summary
ERROR: [Loader Message] Code 0 : vkCreateInstance: Found no drivers!
Cannot create Vulkan instance.
This problem is often caused by a faulty installation of the Vulkan driver or attempting to use a GPU that does not support Vulkan.
ERROR at /tmp/vulkan-tools-20241221-15121-nec5zd/Vulkan-Tools-1.4.304/vulkaninfo/./vulkaninfo.h:456:vkCreateInstance failed with ERROR_INCOMPATIBLE_DRIVERvulkaninfo --summary | rg driver
VK_LUNARG_direct_driver_loading        : extension revision 1
	driverVersion      = 0.2.2019
	driverID           = DRIVER_ID_MOLTENVK
	driverName         = MoltenVK
	driverInfo         = 1.2.11
	driverUUID         = 4d564b00-0000-27e3-0f02-020700000000

New build:

XDG_DATA_DIRS=/tmp vulkaninfo --summary | rg driver
VK_LUNARG_direct_driver_loading        : extension revision 1
	driverVersion      = 0.2.2019
	driverID           = DRIVER_ID_MOLTENVK
	driverName         = MoltenVK
	driverInfo         = 1.2.11
	driverUUID         = 4d564b00-0000-27e3-0f02-020700000000

@github-actions github-actions bot added the macos-only Formula depends on macOS label Jan 17, 2025
Copy link
Contributor

github-actions bot commented Feb 8, 2025

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale No recent activity label Feb 8, 2025
@cho-m cho-m removed the stale No recent activity label Feb 10, 2025
@cho-m cho-m marked this pull request as ready for review February 10, 2025 17:51
@cho-m
Copy link
Member Author

cho-m commented Feb 10, 2025

Would be nicer to test within molten-vk but dependency tree makes this complicated. vulkan-tools is the easiest way to check Vulkan devices but it has a dependency on molten-vk.

Just added test to vulkan-tools which will fail on existing bottle:

==> /opt/homebrew/Cellar/vulkan-tools/1.4.307/bin/vulkaninfo --summary
ERROR: [Loader Message] Code 0 : vkCreateInstance: Found no drivers!
Cannot create Vulkan instance.
This problem is often caused by a faulty installation of the Vulkan driver or attempting to use a GPU that does not support Vulkan.
ERROR at /tmp/vulkan-tools-20250130-18179-16lo75/Vulkan-Tools-1.4.307/vulkaninfo/./vulkaninfo.h:574:vkCreateInstance failed with ERROR_INCOMPATIBLE_DRIVER

Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Feb 10, 2025
@BrewTestBot BrewTestBot added this pull request to the merge queue Feb 10, 2025
Merged via the queue into master with commit b570261 Feb 10, 2025
15 checks passed
@BrewTestBot BrewTestBot deleted the molten-vk-icd branch February 10, 2025 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. macos-only Formula depends on macOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

molten-vk package should install ICD json file to etc instead of share
3 participants