pdnsrec 4.5.1

[chenrui333]

Created with brew bump-formula-pr.

[chenrui333]

Error: Failed changing rpath in /opt/homebrew/Cellar/pdnsrec/4.5.1/sbin/pdns_recursor
  from /opt/homebrew/opt/boost/lib
    to @@HOMEBREW_PREFIX@@/opt/boost/lib
Error: Unrecognized Mach-O load command: 0x00

[carlocab]

Error: Failed changing rpath in /opt/homebrew/Cellar/pdnsrec/4.5.1/sbin/pdns_recursor
  from /opt/homebrew/opt/boost/lib
    to @@HOMEBREW_PREFIX@@/opt/boost/lib
Error: Unrecognized Mach-O load command: 0x00

@woodruffw any chance you can take a look at this?

[carlocab]

The problem seems to be that /usr/local/opt/boost/lib appears several times:

❯ otool -l pdns_recursor | rg -A2 LC_RPATH
          cmd LC_RPATH
      cmdsize 40
         path /usr/local/opt/boost/lib (offset 12)
--
          cmd LC_RPATH
      cmdsize 40
         path /usr/local/opt/boost/lib (offset 12)
--
          cmd LC_RPATH
      cmdsize 40
         path /usr/local/opt/boost/lib (offset 12)

[carlocab]

Opened an issue at Homebrew/ruby-macho#356.

[carlocab]

Should be fixed by Homebrew/brew#11387.

[carlocab]

Fixed in Homebrew/brew#11391. Restarting CI.

[carlocab]

Hmmm, looks like the fix didn't take.

[carlocab]

Not sure why, as I can't reproduce the failure locally when I try to use MachO::Tools.change_rpath on it (which is essentially what brew does).

Let's try rebasing and see if that helps (even if I have no idea why it should). Otherwise, we can try deleting those LC_RPATH entries in the install method directly. They're not needed.

[carlocab]

Ah, wait, no, the error is different:

Error: No such runtime path: /opt/homebrew/opt/boost/lib

I see. This can be fixed.

[carlocab]

Homebrew/brew#11392

[carlocab]

Missed the Mojave build failure:

Undefined symbols for architecture x86_64:
  "MOADNSParser::init(bool, std::__1::basic_string_view<char, std::__1::char_traits<char> > const&)", referenced from:
      MOADNSParser::MOADNSParser(bool, char const*, unsigned int) in axfr-retriever.o
      MOADNSParser::MOADNSParser(bool, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) in ixfr.o
      MOADNSParser::MOADNSParser(bool, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) in pdns_recursor.o
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)

This was present also in previous runs, and is unrelated to the duplicate RPATH bug.

[carlocab]

I think Mojave libc++ is just too old. See also PowerDNS/pdns#10270.

[carlocab]

Added dependency on Catalina.

Let's try to get this to build on Mojave first

[BrewTestBot]

🤖 A scheduled task has triggered a merge.