Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openshift-cli 4.9 #90407

Closed
wants to merge 1 commit into from
Closed

openshift-cli 4.9 #90407

wants to merge 1 commit into from

Conversation

anothertobi
Copy link

The upstream repository changed from tag-based versioning to branch-based versioning. Further, the Makefile was changed upstream and therefore this updates the patch enabling darwin-arm64 builds.

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@BrewTestBot BrewTestBot added the go Go use is a significant feature of the PR or issue label Dec 4, 2021
@SMillerDev
Copy link
Member

Please make a new pull request upstream with the changed makefile then.

@anothertobi
Copy link
Author

anothertobi commented Dec 4, 2021

Please make a new pull request upstream with the changed makefile then.

There are no other changes required in the Makefile besides openshift/oc#889. It's just the merge result that changed, and therefore the patch isn't up-to-date. That's why I replaced it with the output of gh pr diff https://github.com/openshift/oc/pull/889 --patch (only surrounding lines changed, but the ones starting with + are the same).

tag: "openshift-clients-4.6.0-202006250705.p0",
revision: "51011e4849252c723b520643d27d3fa164d28c61"
version "4.6.0"
branch: "release-4.9"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A branch is a moving target, which makes these builds non-reproducible, which we shouldn't have. Why have upstream stopped tagging releases?

Copy link
Author

@anothertobi anothertobi Dec 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why exactly they stopped tagging releases. I suspect that they are doing global releases, with one version across all repos relevant for OCP4, and reference the latest commits of the branches for that release in a global configuration.

This is an automated issue mentioning which branches are frozen for the "global" release: openshift/oc#180

Nevertheless, I updated the PR to point to the latest commit of the release-4.9 branch, which is the latest stable branch for OCP4. This makes the builds reproducible.

@github-actions
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale No recent activity label Dec 26, 2021
@anothertobi anothertobi requested a review from carlocab December 26, 2021 14:33
The upstream repository changed from tag-based versioning to
branch-based versioning. Further, the Makefile was changed
upstream and therefore this updates the patch enabling
darwin-arm64 builds.
@SMillerDev
Copy link
Member

Since this strategy goes against our acceptable formulae requirements we can not accept this change. Unless upstream has some sort of tagged versions I think we'll have to deprecate the formula instead.

@github-actions github-actions bot removed the stale No recent activity label Dec 30, 2021
@github-actions github-actions bot added the outdated PR was locked due to age label Jan 30, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
go Go use is a significant feature of the PR or issue outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants