-
-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
openshift-cli 4.9 #90407
openshift-cli 4.9 #90407
Conversation
Please make a new pull request upstream with the changed makefile then. |
There are no other changes required in the Makefile besides openshift/oc#889. It's just the merge result that changed, and therefore the patch isn't up-to-date. That's why I replaced it with the output of |
Formula/openshift-cli.rb
Outdated
tag: "openshift-clients-4.6.0-202006250705.p0", | ||
revision: "51011e4849252c723b520643d27d3fa164d28c61" | ||
version "4.6.0" | ||
branch: "release-4.9" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A branch is a moving target, which makes these builds non-reproducible, which we shouldn't have. Why have upstream stopped tagging releases?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why exactly they stopped tagging releases. I suspect that they are doing global releases, with one version across all repos relevant for OCP4, and reference the latest commits of the branches for that release in a global configuration.
This is an automated issue mentioning which branches are frozen for the "global" release: openshift/oc#180
Nevertheless, I updated the PR to point to the latest commit of the release-4.9
branch, which is the latest stable branch for OCP4. This makes the builds reproducible.
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
The upstream repository changed from tag-based versioning to branch-based versioning. Further, the Makefile was changed upstream and therefore this updates the patch enabling darwin-arm64 builds.
Since this strategy goes against our acceptable formulae requirements we can not accept this change. Unless upstream has some sort of tagged versions I think we'll have to deprecate the formula instead. |
The upstream repository changed from tag-based versioning to branch-based versioning. Further, the Makefile was changed upstream and therefore this updates the patch enabling darwin-arm64 builds.
brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingbrew install --build-from-source <formula>
)? If this is a new formula, does it passbrew audit --new <formula>
?