fix: LEAP-856: Prevent submitting empty annotation by hotkeys (#5663)

* fix: LEAP-856: Prevent submitting empty annotation by hotkeys * ci: Build frontend Workflow run: https://github.com/HumanSignal/label-studio/actions/runs/8538222335 * fix: LEAP-856: Prevent submitting empty annotation by hotkeys * ci: Build frontend Workflow run: https://github.com/HumanSignal/label-studio/actions/runs/8538878701 --------- Co-authored-by: robot-ci-heartex <[email protected]> Co-authored-by: Gondragos <[email protected]>
HumanSignal · Apr 4, 2024 · 24f9ebc · 24f9ebc
1 parent f9f103e
commit 24f9ebc
Show file tree

Hide file tree

Showing 6 changed files with 18 additions and 16 deletions.
diff --git a/web/dist/apps/labelstudio/version.json b/web/dist/apps/labelstudio/version.json
@@ -1,6 +1,6 @@
 {
-  "message": "Merge remote-tracking branch 'origin/develop' into fb-optic-591",
-  "commit": "1dcdd169df8071f971df1be05d557c1f18f83804",
-  "date": "2024-04-03T21:07:25.000Z",
-  "branch": "fb-optic-591"
+  "message": "Merge branch 'fb-leap-856/deny-empty' of ssh://github.com/heartexlabs/label-studio into fb-leap-856/deny-empty",
+  "commit": "f101a29d79597af4df007cac70f34d7ed36f90be",
+  "date": "2024-04-03T12:41:08.000Z",
+  "branch": "fb-leap-856/deny-empty"
 }
diff --git a/web/dist/libs/datamanager/version.json b/web/dist/libs/datamanager/version.json
@@ -1,6 +1,6 @@
 {
-  "message": "Merge remote-tracking branch 'origin/develop' into fb-optic-591",
-  "commit": "1dcdd169df8071f971df1be05d557c1f18f83804",
-  "date": "2024-04-03T21:07:25.000Z",
-  "branch": "fb-optic-591"
+  "message": "Merge branch 'fb-leap-856/deny-empty' of ssh://github.com/heartexlabs/label-studio into fb-leap-856/deny-empty",
+  "commit": "f101a29d79597af4df007cac70f34d7ed36f90be",
+  "date": "2024-04-03T12:41:08.000Z",
+  "branch": "fb-leap-856/deny-empty"
 }
diff --git a/web/dist/libs/editor/main.js b/web/dist/libs/editor/main.js
diff --git a/web/dist/libs/editor/main.js.map b/web/dist/libs/editor/main.js.map
diff --git a/web/dist/libs/editor/version.json b/web/dist/libs/editor/version.json
@@ -1,6 +1,6 @@
 {
-  "message": "Merge remote-tracking branch 'origin/develop' into fb-optic-591",
-  "commit": "1dcdd169df8071f971df1be05d557c1f18f83804",
-  "date": "2024-04-03T21:07:25.000Z",
-  "branch": "fb-optic-591"
+  "message": "Merge branch 'fb-leap-856/deny-empty' of ssh://github.com/heartexlabs/label-studio into fb-leap-856/deny-empty",
+  "commit": "f101a29d79597af4df007cac70f34d7ed36f90be",
+  "date": "2024-04-03T12:41:08.000Z",
+  "branch": "fb-leap-856/deny-empty"
 }
diff --git a/web/libs/editor/src/stores/AppStore.js b/web/libs/editor/src/stores/AppStore.js
@@ -327,11 +327,13 @@ export default types
       if (self.hasInterface('submit', 'update', 'review')) {
         hotkeys.addNamed('annotation:submit', () => {
           const annotationStore = self.annotationStore;
+          const shouldDenyEmptyAnnotation = self.hasInterface('annotations:deny-empty');
+          const entity = annotationStore.selected;
+          const areResultsEmpty = entity.results.length === 0;
 
+          if (shouldDenyEmptyAnnotation && areResultsEmpty) return;
           if (annotationStore.viewingAll) return;
 
-          const entity = annotationStore.selected;
-
           entity?.submissionInProgress();
 
           if (self.hasInterface('review')) {