feat: OPTIC-1183: Improve is_delete flow #6473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for heartex-docs canceled.
|
✅ Deploy Preview for label-studio-docs-new-theme canceled.
|
wesleylima
approved these changes
Oct 6, 2024
fix linting, my conf in local is diferent??? fix linting, my conf in local is diferent??? fix linting, my conf in local is diferent???
luarmr
force-pushed
the
fb-optic-1183/improve-is_delete-flow
branch
from
d01ecf9 to
6a2a05c
Compare
luarmr
force-pushed
the
fb-optic-1183/improve-is_delete-flow
branch
from
c140334 to
5c98252
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #6473 +/- ##
========================================
Coverage 76.60% 76.60%
========================================
Files 169 169
Lines 13775 13775
========================================
Hits 10553 10553
Misses 3222 3222
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While investigating an organization with a large number of users, we realized that this FF check triggers unnecessary calls because it checks users in a loop rather than the request.
This feature flag is fully deprecated on cloud, so we create this initial patch.
We will have a quick follow up to make this more reusable.