Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: PLT-536: rework migration script to use pg_try_advisory_xact_lock #6585

Merged
merged 3 commits into from
Nov 4, 2024

Conversation

farioas
Copy link
Member

@farioas farioas commented Oct 31, 2024

Switch to pg_try_advisory_xact_lock for locked_migrations

@github-actions github-actions bot added the ci label Oct 31, 2024
Copy link

netlify bot commented Oct 31, 2024

Deploy Preview for heartex-docs canceled.

Name Link
🔨 Latest commit e50d8e2
🔍 Latest deploy log https://app.netlify.com/sites/heartex-docs/deploys/672914636e653800081f1d46

Copy link

netlify bot commented Oct 31, 2024

Deploy Preview for label-studio-docs-new-theme canceled.

Name Link
🔨 Latest commit e50d8e2
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-docs-new-theme/deploys/6729146380c6670008a0912e

Copy link

codecov bot commented Oct 31, 2024

Codecov Report

Attention: Patch coverage is 0% with 30 lines in your changes missing coverage. Please review.

Project coverage is 76.64%. Comparing base (656fdfd) to head (9959040).
Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
..._studio/core/management/commands/locked_migrate.py 0.00% 30 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6585      +/-   ##
===========================================
- Coverage    76.73%   76.64%   -0.09%     
===========================================
  Files          169      169              
  Lines        13819    13835      +16     
===========================================
  Hits         10604    10604              
- Misses        3215     3231      +16     
Flag Coverage Δ
pytests 76.64% <0.00%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@farioas farioas force-pushed the fb-PLT-536 branch 2 times, most recently from 305274d to 4c18114 Compare November 1, 2024 16:28
@farioas farioas changed the title ci: PLT-536: switch to pg_advisory_lock for locked_migrations ci: PLT-536: rework migration script to use pg_try_advisory_xact_lock Nov 4, 2024
Copy link
Contributor

@jombooth jombooth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please update the description to describe the solution in greater detail and correct the pg lock function used (should be pg_try_advisory_xact_lock)

@farioas farioas merged commit 64c0794 into develop Nov 4, 2024
35 of 41 checks passed
@farioas farioas deleted the fb-PLT-536 branch November 13, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants