Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: DIA-1794: [FE] Home page (+Tailwind and shadcn integration) #7009

Merged
merged 44 commits into from
Mar 6, 2025

Conversation

nick-skriabin
Copy link
Member

@nick-skriabin nick-skriabin commented Feb 3, 2025

Introducing new Homepage and integration of Tailwind and shadcn.

Documentation for the new UI component and usage of Tailwind is coming separately. Will cover the usage of the components, how to add new ones, how to properly use Tailwind in the context of Label Studio.

There will also be some follow up refactoring to cleanup transition period inconsistencies.

image

@nick-skriabin nick-skriabin requested a review from a team as a code owner February 3, 2025 12:54
@github-actions github-actions bot added the feat label Feb 3, 2025
Copy link

netlify bot commented Feb 3, 2025

Deploy Preview for heartex-docs canceled.

Name Link
🔨 Latest commit 22506cd
🔍 Latest deploy log https://app.netlify.com/sites/heartex-docs/deploys/67c98967592abd00090d6491

Copy link

netlify bot commented Feb 3, 2025

Deploy Preview for label-studio-docs-new-theme canceled.

Name Link
🔨 Latest commit 22506cd
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-docs-new-theme/deploys/67c98967411a220008b88857

@nick-skriabin nick-skriabin changed the title feat: DIA-1783: [FE] Prep work - Tailwind + shadcn cross integration in LSO + LSE feat: DIA-1783, DIA-1794: [FE] Prep work - Tailwind + shadcn cross integration in LSO + LSE Feb 3, 2025
Copy link

codecov bot commented Feb 3, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 77.17%. Comparing base (4108f9e) to head (22506cd).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
label_studio/core/views.py 33.33% 4 Missing ⚠️
label_studio/users/views.py 66.66% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7009      +/-   ##
===========================================
- Coverage    77.20%   77.17%   -0.04%     
===========================================
  Files          187      187              
  Lines        14484    14491       +7     
===========================================
+ Hits         11183    11184       +1     
- Misses        3301     3307       +6     
Flag Coverage Δ
pytests 77.17% <50.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nick-skriabin
Copy link
Member Author

nick-skriabin commented Feb 13, 2025

/git merge

Workflow run
Error: Workflow failed

@nick-skriabin
Copy link
Member Author

nick-skriabin commented Feb 21, 2025

/docker build

Workflow run
Docker image was pushed with the tag 20250221.173814-fb-dia-1783-tailwind-next-2a435a726

Copy link
Collaborator

@hlomzik hlomzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One line description for 100+ files with lot of new components, new approaches, changes without explanations, etc?
Please let's be diligent and respect the quality of our codebase. I already see a bunch of issues and asking for another round of reviews.

@nick-skriabin nick-skriabin requested a review from hlomzik March 4, 2025 17:03
@nick-skriabin nick-skriabin changed the title feat: DIA-1794: [FE] Prep work - Tailwind + shadcn cross integration in LSO + LSE feat: DIA-1794: [FE] Home page (+Tailwind and shadcn integration) Mar 4, 2025
@nick-skriabin nick-skriabin requested a review from hlomzik March 4, 2025 18:34
Copy link
Collaborator

@hlomzik hlomzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately there are still things to fix. Plus we have to run all tests again

@nick-skriabin nick-skriabin force-pushed the fb-dia-1783/tailwind-next branch from 3e53ec2 to 60bdf1b Compare March 4, 2025 21:11
@bmartel
Copy link
Contributor

bmartel commented Mar 5, 2025

/git merge develop

Workflow run
Successfully merged: Already up to date.

@bmartel
Copy link
Contributor

bmartel commented Mar 6, 2025

/git merge develop

Workflow run
Successfully merged: 3 files changed, 20 insertions(+), 10 deletions(-)

@nick-skriabin nick-skriabin merged commit 9844eaf into develop Mar 6, 2025
41 of 43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants