-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: IPv6 issues for nginx #7082
Conversation
👷 Deploy request for label-studio-docs-new-theme pending review.Visit the deploys page to approve it
|
👷 Deploy request for heartex-docs pending review.Visit the deploys page to approve it
|
Did you test this out? I have no k8s cluster with ipv6 to check :) |
Yes, I have tested @farioas Here is how the
After I process this file with this new code: nameservers=$(awk '$1=="nameserver" {
ns = $2;
# Capture only IPv6 addresses (they contain a colon and no dot)
if (ns ~ /^[0-9a-fA-F:]+$/ && ns ~ /:/ && ns !~ /\./) {
printf "[%s] ", ns;
} else {
# IPv4 addresses
printf "%s ", ns;
}
}' /etc/resolv.conf)
echo "resolver $nameservers;" > $OPT_DIR/nginx/resolv.conf Here is how the resulting
It looks correct to me. |
Which version of the packaged docker container is this fix expected to be implemented? |
It's available in docker image tag: |
PR fulfills these requirements
[fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made
ex.fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
Change has impacts in these area(s)
(check all that apply)
Describe the reason for change
(link to issue, supportive screenshots etc.)
Bug with processing IPv6
#7081
What does this fix?
(if this is a bug fix)
Correctly processes IPv6
What is the new behavior?
(if this is a breaking or feature change)
Be able to run in k8s environments with IPv6
What is the current behavior?
(if this is a breaking or feature change)
Nginx container fails due to the bug
What libraries were added/updated?
(list all with version changes)
N/A
Does this change affect performance?
(if so describe the impacts positive or negative)
No
Does this change affect security?
(if so describe the impacts positive or negative)
No
What alternative approaches were there?
(briefly list any if applicable)
What feature flags were used to cover this change?
(briefly list any if applicable)
Does this PR introduce a breaking change?
(check only one)
What level of testing was included in the change?
(check all that apply)
Which logical domain(s) does this change affect?
(for bug fixes/features, be as precise as possible. ex. Authentication, Annotation History, Review Stream etc.)
Proxy for thee main app