Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: LEAP-1819: Prevent drawing actions outside the stage area #7084

Merged
merged 10 commits into from
Feb 21, 2025

Conversation

Gondragos
Copy link
Collaborator

Added a new inStage method to verify if events occur within the stage boundaries. Updated multiple event handlers (e.g., mousedownEv, clickEv, dblclickEv) to halt actions when the event is outside the stage dimensions, improving boundary validation.

PR fulfills these requirements

  • Commit message(s) and PR title follow the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
  • Tests for the changes have been added/updated (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • The best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
  • Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)

(check all that apply)

  • Product design
  • Backend (Database)
  • Backend (API)
  • Frontend

Does this PR introduce a breaking change?

(check only one)

  • Yes, and covered entirely by feature flag(s)
  • Yes, and covered partially by feature flag(s)
  • No
  • Not sure (briefly explain the situation below)

Added a new `inStage` method to verify if events occur within the stage boundaries. Updated multiple event handlers (e.g., `mousedownEv`, `clickEv`, `dblclickEv`) to halt actions when the event is outside the stage dimensions, improving boundary validation.
@github-actions github-actions bot added the fix label Feb 14, 2025
Copy link

netlify bot commented Feb 14, 2025

Deploy Preview for label-studio-docs-new-theme canceled.

Name Link
🔨 Latest commit 287cfb5
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-docs-new-theme/deploys/67b8495e5d87a50008186213

Copy link

netlify bot commented Feb 14, 2025

Deploy Preview for heartex-docs canceled.

Name Link
🔨 Latest commit 287cfb5
🔍 Latest deploy log https://app.netlify.com/sites/heartex-docs/deploys/67b8495e9a13f5000929710d

Replaced `inStage` method with `isAllowedInteraction` for better clarity and expanded validation. Updates ensure interactions respect group-specific constraints, particularly for segmentation, and improve maintainability by applying consistent checks across tools.
@Gondragos
Copy link
Collaborator Author

Gondragos commented Feb 20, 2025

/git merge

Workflow run
Successfully merged: 9 files changed, 116 insertions(+), 58 deletions(-)

@Gondragos
Copy link
Collaborator Author

Gondragos commented Feb 20, 2025

/git merge

Workflow run
Successfully merged: 7 files changed, 24 insertions(+), 14 deletions(-)

@MihajloHoma
Copy link
Contributor

MihajloHoma commented Feb 21, 2025

/git merge

Workflow run
Successfully merged: 13 files changed, 52 insertions(+), 25 deletions(-)

@Gondragos Gondragos merged commit debc186 into develop Feb 21, 2025
34 checks passed
@Gondragos Gondragos deleted the fb-LEAP-1819 branch February 21, 2025 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants