-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: LEAP-1819: Prevent drawing actions outside the stage area #7084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a new `inStage` method to verify if events occur within the stage boundaries. Updated multiple event handlers (e.g., `mousedownEv`, `clickEv`, `dblclickEv`) to halt actions when the event is outside the stage dimensions, improving boundary validation.
✅ Deploy Preview for label-studio-docs-new-theme canceled.
|
✅ Deploy Preview for heartex-docs canceled.
|
Replaced `inStage` method with `isAllowedInteraction` for better clarity and expanded validation. Updates ensure interactions respect group-specific constraints, particularly for segmentation, and improve maintainability by applying consistent checks across tools.
It should be the same as wait
3daea49
to
5bba0ba
Compare
/git merge
|
yyassi-heartex
approved these changes
Feb 20, 2025
/git merge
|
/git merge
|
MihajloHoma
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new
inStage
method to verify if events occur within the stage boundaries. Updated multiple event handlers (e.g.,mousedownEv
,clickEv
,dblclickEv
) to halt actions when the event is outside the stage dimensions, improving boundary validation.PR fulfills these requirements
[fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made
ex.fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
Change has impacts in these area(s)
(check all that apply)
Does this PR introduce a breaking change?
(check only one)