-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: OPTIC-1643: Copy Data Manager Quick View link to annotation or region #7122
Conversation
✅ Deploy Preview for heartex-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for label-studio-docs-new-theme ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
… set, and gate that setting behind the same FF
web/libs/editor/src/components/AnnotationsCarousel/AnnotationButton.tsx
Outdated
Show resolved
Hide resolved
web/libs/editor/src/components/SidePanels/Components/RegionContextMenu.tsx
Outdated
Show resolved
Hide resolved
/git merge
|
@yyassi-heartex Can you re-review the two last commits.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
had 1 question, but overall looks good
/git merge
|
PR fulfills these requirements
[fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made
ex.fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
Change has impacts in these area(s)
(check all that apply)
Describe the reason for change
annotations:copy-link
to gate this functionality behind the FF, but also so that this functionality is only restricted to QuickView in LSO/LSE.What feature flags were used to cover this change?
fflag_feat_front_optic_1553_url_based_region_visibility_short
Does this PR introduce a breaking change?
(check only one)
What level of testing was included in the change?
(check all that apply)
Which logical domain(s) does this change affect?
Quick View > AnnotationButton + RegionControls