Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: DIA-1935: fix JWT feature flag #7128

Merged
merged 11 commits into from
Feb 26, 2025
Merged

fix: DIA-1935: fix JWT feature flag #7128

merged 11 commits into from
Feb 26, 2025

Conversation

pakelley
Copy link
Contributor


PR fulfills these requirements

  • Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
  • Tests for the changes have been added/updated (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
  • Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)

(check all that apply)

  • Product design
  • Backend (Database)
  • Backend (API)
  • Frontend

Describe the reason for change

(link to issue, supportive screenshots etc.)

What does this fix?

(if this is a bug fix)

What is the new behavior?

(if this is a breaking or feature change)

What is the current behavior?

(if this is a breaking or feature change)

What libraries were added/updated?

(list all with version changes)

Does this change affect performance?

(if so describe the impacts positive or negative)

Does this change affect security?

(if so describe the impacts positive or negative)

What alternative approaches were there?

(briefly list any if applicable)

What feature flags were used to cover this change?

(briefly list any if applicable)

Does this PR introduce a breaking change?

(check only one)

  • Yes, and covered entirely by feature flag(s)
  • Yes, and covered partially by feature flag(s)
  • No
  • Not sure (briefly explain the situation below)

What level of testing was included in the change?

(check all that apply)

  • e2e
  • integration
  • unit

Which logical domain(s) does this change affect?

(for bug fixes/features, be as precise as possible. ex. Authentication, Annotation History, Review Stream etc.)

Copy link

netlify bot commented Feb 21, 2025

Deploy Preview for heartex-docs ready!

Name Link
🔨 Latest commit b5f0544
🔍 Latest deploy log https://app.netlify.com/sites/heartex-docs/deploys/67bcf1b9ff87580008ab21a1
😎 Deploy Preview https://deploy-preview-7128--heartex-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 21, 2025

Deploy Preview for label-studio-docs-new-theme ready!

Name Link
🔨 Latest commit b5f0544
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-docs-new-theme/deploys/67bcf1b9c6a1500008f1a012
😎 Deploy Preview https://deploy-preview-7128--label-studio-docs-new-theme.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Feb 21, 2025

Codecov Report

Attention: Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 77.08%. Comparing base (7d086c2) to head (b5f0544).
Report is 22 commits behind head on develop.

Files with missing lines Patch % Lines
label_studio/jwt_auth/middleware.py 80.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7128      +/-   ##
===========================================
- Coverage    77.09%   77.08%   -0.01%     
===========================================
  Files          183      183              
  Lines        14406    14401       -5     
===========================================
- Hits         11106    11101       -5     
  Misses        3300     3300              
Flag Coverage Δ
pytests 77.08% <80.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pakelley pakelley changed the title dev: DIA-1935: add logging dev: DIA-1935: fix JWT feature flag Feb 24, 2025
Copy link
Contributor

@matt-bernstein matt-bernstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic makes sense to me, but any particular reason for removing the debug logs? There's no other indication of why the auth wouldn't work in that case

@pakelley
Copy link
Contributor Author

The logic makes sense to me, but any particular reason for removing the debug logs? There's no other indication of why the auth wouldn't work in that case

Ah, yeah this was debug logging that was added (in a separate PR) to debug this specific issue. Nikolai requested that we remove it again after this, because it will result in lots of noise (as this is called on every request)

@pakelley pakelley changed the title dev: DIA-1935: fix JWT feature flag fix: DIA-1935: fix JWT feature flag Feb 25, 2025
@pakelley pakelley merged commit 441679c into develop Feb 26, 2025
44 of 45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants