feat: LEAP-1896: Add scrollbar support to Visualizer #7165
+87
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for heartex-docs canceled.
|
✅ Deploy Preview for label-studio-docs-new-theme canceled.
|
Introduced a scroll filler element to improve handling of browser scroll size inconsistencies in the Visualizer. Updated relevant methods and styles to adjust layout dynamically based on the calculated scroll size. Added safeguards to mouse events.
Gondragos
force-pushed
the
fb-LEAP-1896/audio-scroll
branch
from
003d550 to
046fb9c
Compare
hlomzik
reviewed
Mar 4, 2025
Renamed `BROWSER_SCROLL_SIZE` to `BROWSER_SCROLLBAR_WIDTH` to provide a clearer description of its purpose. Updated related references and comments to reflect this change, ensuring consistency and maintaining accurate documentation.
Gondragos
force-pushed
the
fb-LEAP-1896/audio-scroll
branch
from
162fe3a to
f315f8b
Compare
Refactored scrollbar logic into a new `initScrollBar` method for better clarity and functionality. Added `scrollbarGutter: stable` for potential consistent scrollbar behavior across browsers.
Updated pixel color comparison coordinates in audio region tests to ensure accuracy and consistency. Added a getter to check the readiness of objects in the model and updated `isReady` logic in test helpers for smoother synchronization.
Added a short wait after verifying the loading bar's absence to ensure the AudioView has completely rendered. This change addresses potential flakiness in tests caused by premature assertions.
hlomzik
reviewed
Mar 5, 2025
hlomzik
approved these changes
Mar 5, 2025
bmartel
approved these changes
Mar 5, 2025
|
/git merge
|
It looks like it was not the problem for tests.
|
/git merge develop
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced a scroll filler element to improve handling of browser scroll size inconsistencies in the Visualizer. Updated relevant methods and styles to adjust the layout dynamically based on the calculated scroll size. Added safeguards to mouse events.
Improvements to scrolling functionality:
web/libs/editor/src/lib/AudioUltra/Common/Utils.ts: Added a new constantBROWSER_SCROLL_SIZEto dynamically calculate the browser scroll size.web/libs/editor/src/lib/AudioUltra/Visual/Visualizer.ts: ImportedBROWSER_SCROLL_SIZEand added a newscrollFillerelement to handle scroll space dynamically. [1] [2]Enhancements to scroll handling logic:
web/libs/editor/src/lib/AudioUltra/Visual/Visualizer.ts: Updated thesetScrollLeftmethod to adjust the wrapper's scroll position and introduced a new_setScrollLeftmethod for internal scroll handling.web/libs/editor/src/lib/AudioUltra/Visual/Visualizer.ts: Modified thecenterToCurrentTimemethod to use the updatedsetScrollLeftmethod for centering.web/libs/editor/src/lib/AudioUltra/Visual/Visualizer.ts: Added an event listener for thescrollevent to update the scroll position and invoke the waveform scroll event.Adjustments for improved user experience:
web/libs/editor/src/lib/AudioUltra/Visual/Visualizer.ts: Adjusted the container height to include the browser scroll size, ensuring proper layout and spacing.web/libs/editor/src/lib/AudioUltra/Visual/Visualizer.ts: Updated theupdateSizemethod to refresh the scroll filler and set the scroll position correctly.);