Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: LEAP-1893: LEAP-1900: Add setting to toggle region looping and autoplay #7166

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

hlomzik
Copy link
Collaborator

@hlomzik hlomzik commented Mar 4, 2025

Two new settings:

  • Toggle region looping when playing; default value is changed to false to not annoy users.
  • Toggle auto-play of new segments (unlabeled regions); default stays true.

AudioUltra view.tsx was changed to move provider with settings higher so they can be used by both Audio and Controls.

Before
Screenshot 2025-03-06 at 14 12 57
After
Screenshot 2025-03-06 at 14 09 21

Improved styles for audio controls:

  • uniform font size for all controls
  • increase modal width to fit new settings
  • adjust paddings for better apearance
  • use our common tooltips for info icon

Fix styles and types for uikit's toggle and label:

  • proper ref typing
  • fix issues
  • remove font-size from a wrong place - it was overriding sizing params

Default value is changed to false to not annoy users.
In order to do so AudioUltra view was changed to move provider with settings higher.
@github-actions github-actions bot added the feat label Mar 4, 2025
Copy link

netlify bot commented Mar 4, 2025

Deploy Preview for label-studio-docs-new-theme ready!

Name Link
🔨 Latest commit 2b308b2
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-docs-new-theme/deploys/67cb214765391e00080ad8a6
😎 Deploy Preview https://deploy-preview-7166--label-studio-docs-new-theme.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Mar 4, 2025

Deploy Preview for heartex-docs ready!

Name Link
🔨 Latest commit 2b308b2
🔍 Latest deploy log https://app.netlify.com/sites/heartex-docs/deploys/67cb2147b34e70000846ef4d
😎 Deploy Preview https://deploy-preview-7166--heartex-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hlomzik hlomzik changed the title feat: LEAP-1893: Add setting to toggle region looping feat: LEAP-1893: [WIP] Add setting to toggle region looping Mar 5, 2025
hlomzik added 4 commits March 5, 2025 16:10
Previously if it was after the region or just at the end of it,
the cursor was moved to the end of the region,
which stops playing if looping is disabled.
Now it's always moved to the beginning of the region.
- uniform font size for all controls
- increase modal width to fit new settings
- adjust paddings for better apearance
- use our common tooltips for info icon
- proper ref typing
- fix issues
- remove font-size from a wrong place - it was overriding sizing params
@hlomzik hlomzik changed the title feat: LEAP-1893: [WIP] Add setting to toggle region looping feat: LEAP-1893: LEAP-1900: Add setting to toggle region looping and autoplay Mar 6, 2025
@hlomzik
Copy link
Collaborator Author

hlomzik commented Mar 7, 2025

/git merge

Workflow run
Successfully merged: create mode 100644 web/tsconfig.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant