-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: LEAP-1893: LEAP-1900: Add setting to toggle region looping and autoplay #7166
Open
hlomzik
wants to merge
7
commits into
develop
Choose a base branch
from
fb-leap-1893/audio-regions-settings
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Default value is changed to false to not annoy users. In order to do so AudioUltra view was changed to move provider with settings higher.
✅ Deploy Preview for label-studio-docs-new-theme ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for heartex-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Previously if it was after the region or just at the end of it, the cursor was moved to the end of the region, which stops playing if looping is disabled. Now it's always moved to the beginning of the region.
- uniform font size for all controls - increase modal width to fit new settings - adjust paddings for better apearance - use our common tooltips for info icon
- proper ref typing - fix issues - remove font-size from a wrong place - it was overriding sizing params
/git merge
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two new settings:
AudioUltra
view.tsx
was changed to move provider with settings higher so they can be used by both Audio and Controls.Improved styles for audio controls:
Fix styles and types for uikit's toggle and label: