Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: OPTIC-1780: Ignoring PermissionDenied exceptions in Sentry #7172

Merged
merged 1 commit into from
Mar 5, 2025

Conversation

mcanu
Copy link
Contributor

@mcanu mcanu commented Mar 5, 2025

This pull request includes changes to centralize the management of ignored exceptions for Sentry in the label_studio project. The most important changes are the addition of a new setting for ignored exceptions and the refactoring of the event processor to use this new setting.

Centralization of ignored exceptions:

Refactoring to use the new setting:

  • label_studio/core/utils/sentry.py: Modified the event_processor function to reference settings.SENTRY_IGNORED_EXCEPTIONS instead of hardcoding the list of ignored exceptions.

  • Ignoring now PermissionDenied exception

@github-actions github-actions bot added the fix label Mar 5, 2025
Copy link

netlify bot commented Mar 5, 2025

Deploy Preview for label-studio-docs-new-theme canceled.

Name Link
🔨 Latest commit f094dba
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-docs-new-theme/deploys/67c8afde7529df00080736d2

Copy link

netlify bot commented Mar 5, 2025

Deploy Preview for heartex-docs canceled.

Name Link
🔨 Latest commit f094dba
🔍 Latest deploy log https://app.netlify.com/sites/heartex-docs/deploys/67c8afde80b65f0008c041a3

Copy link

codecov bot commented Mar 5, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 77.20%. Comparing base (7487d6e) to head (f094dba).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
label_studio/core/utils/sentry.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #7172   +/-   ##
========================================
  Coverage    77.19%   77.20%           
========================================
  Files          187      187           
  Lines        14478    14479    +1     
========================================
+ Hits         11177    11179    +2     
+ Misses        3301     3300    -1     
Flag Coverage Δ
pytests 77.20% <50.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mcanu mcanu merged commit 096cfd6 into develop Mar 5, 2025
46 of 47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants