Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: LEAP-1907: Migrate EnterpriseBadge to UI library #7173

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

Gondragos
Copy link
Collaborator

Moved EnterpriseBadge from the application codebase to the shared UI library for better reusability and modularity. Updated relevant imports and added a Storybook story for the badge. This change also includes moving the associated CSS and related IconSpark to the UI library and usage of scss modules.

image

Moved EnterpriseBadge from the application codebase to the shared UI library for better reusability and modularity. Updated relevant imports and added a Storybook story for the badge. This change also includes moving the associated CSS and related IconSpark to the UI library and usage of scss modules.
Copy link

netlify bot commented Mar 6, 2025

Deploy Preview for label-studio-docs-new-theme canceled.

Name Link
🔨 Latest commit b3f01b5
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-docs-new-theme/deploys/67cb4d71d2e042000867361f

Copy link

netlify bot commented Mar 6, 2025

Deploy Preview for heartex-docs canceled.

Name Link
🔨 Latest commit b3f01b5
🔍 Latest deploy log https://app.netlify.com/sites/heartex-docs/deploys/67cb4d718ef339000803f451

@Gondragos Gondragos requested a review from a team March 6, 2025 07:46
# Conflicts:
#	web/apps/labelstudio/src/pages/CreateProject/CreateProject.jsx
@Gondragos Gondragos requested a review from hlomzik March 6, 2025 15:36
Copy link

@nass600 nass600 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the margin related comments looks good to me

@Gondragos
Copy link
Collaborator Author

Gondragos commented Mar 7, 2025

/git merge

Workflow run
Successfully merged: Already up to date.

Added a `className` prop to the `EnterpriseBadge` component to allow external styling. Updated usage instances in CreateProject and GeneralSettings pages to apply a margin class for proper spacing. Also removed hardcoded margin from the component's default styles.
@Gondragos Gondragos requested a review from nass600 March 7, 2025 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants