Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#124] Tests for s3 dataset registration #125

Merged
merged 9 commits into from
Jun 7, 2024

Conversation

pkdash
Copy link
Collaborator

@pkdash pkdash commented Apr 9, 2024

In addition to tests for s3 dataset registration, this work also includes better error handling when interacting with s3 storage.

@pkdash pkdash linked an issue May 14, 2024 that may be closed by this pull request
@pkdash pkdash marked this pull request as ready for review May 29, 2024 21:46
@pkdash pkdash requested a review from Maurier June 3, 2024 18:47
Copy link
Collaborator

@Maurier Maurier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@pkdash pkdash merged commit b0fef37 into develop Jun 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tests and error handling for registering S3 dataset
2 participants