Fix GeckoViewPlugin build errors. #50
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah I haven't seen this PR before! I'm not sure why I didn't see the email. Have you tested the plugin in a device build as well? |
IanPhilips
reviewed
Apr 11, 2023
| @@ -12,4 +12,4 @@ org.gradle.jvmargs=-Xmx1536m | |||
| # http://www.gradle.org/docs/current/userguide/multi_project_builds.html#sec:decoupled_projects | |||
| # org.gradle.parallel=true | |||
|
|
|||
|
|
|||
| android.useAndroidX=true | |||
There was a problem hiding this comment.
If you remove this line, the build will fail.
AndroidX is a major improvement to the original Android Support Library, which is no longer maintained.
https://developer.android.com/jetpack/androidx
There was a problem hiding this comment.
For what it's worth, I dealt with build errors to and left info about my experience here (including stuff on androidx): #28 (comment)
I tested it on the Quest 2, and I was able to use the microphone by adding some code. |
YourBestDeveloper
force-pushed
the
master
branch
from
8b55244 to
bca9121
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Changes
Result