wl: Change IM context functions signature #671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psaavedra
force-pushed
the
psaavedra/change_signature_im_context
branch
from
ffaf9ee to
4faaba3
Compare
The input method context is now defined and assigned to the View once this is added to a Viewport, in cog_viewport_add(). It is not possible before because we need to have access to the wl_surface associated to the Viewport->Window for configuring the IM context.
psaavedra
force-pushed
the
psaavedra/change_signature_im_context
branch
from
4faaba3 to
e25b826
Compare
aperezdc
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The input method context is now defined and assigned to the View once this is added to a Viewport, in
cog_viewport_add(). It is not possible before because we need to have access to thewl_surfaceassociated to the Viewport->Window for configuring the IM context.