Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add script to install Zed inside the container #94

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

justinmichaud
Copy link
Contributor

In the interest of supporting more editors, this patch adds a script to install Zed. It would be nice for all of the most common editors to be supported, but certainly the Free ones should be included.

In general, I would love to know the stance of this project on including features like this. I don't use or have a licence for Sublime or CLion, although I would vote that this repository should support using them if somebody wants to submit a patch. That is, I think we should support the set of things that anybody might use, rather than the subset that everybody uses. For example, I am not a Vim/Emacs user, but I would see value personally if someone shared a good default configuration that worked in the container with clangd.

At the same time, I understand this might cause some dramatic scope creep / maintenance overhead.

In particular, for this PR, Zed requires workarounds in the container to get GPU access. For that reason, regardless of the result of the discussion above, I think this install script can be included without setting the precedent that every editor can be included.

This should land after the VSCodium PR. I didn't bother to duplicate that PR since I assumed any feedback on that PR would immediately apply here.

- Add helpful clangd default settings
- Make VSCode .application file by default
@TingPing
Copy link
Member

TingPing commented Jan 29, 2025

In the interest of supporting more editors

I'm not sure this is a goal. The purpose of the SDK was to standardize the developer experience.

Rather what I would prefer, and started a while back but didn't finish, is to make a generic command like wkdev-export-application or similar to effectively do what install_xdg() does here in a more generic way.

If we could make that function generic at least that would mean these editor specific commands become more simple at least, so less of a burden to support more.

In particular, for this PR, Zed requires workarounds in the container to get GPU access.

You mean installing vulkan-tools? The container should already have mesa, vscode needs it too, but we can add that if needed.

@justinmichaud
Copy link
Contributor Author

If we could make that function generic at least that would mean these editor specific commands become more simple at least, so less of a burden to support more.

I think this makes sense. Although I still like the idea of being able to pick up a known-good config for a popular editor as a starting point for new contributors.

You mean installing vulkan-tools? The container should already have mesa, vscode needs it too, but we can add that if needed.

Yeah, if there are no objections we can just do that. I figured it might be too much

@TingPing
Copy link
Member

Although I still like the idea of being able to pick up a known-good config for a popular editor as a starting point for new contributors

I'd be ok with that if the hard part was shared (exports).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants