-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Tile manager component implementation #1402
Draft
mtsvyatkova
wants to merge
187
commits into
master
Choose a base branch
from
mtsvyatkova/feat-1379-tile-manager
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…om/IgniteUI/igniteui-webcomponents into mtsvyatkova/feat-1379-tile-manager
…manager-resizing # Conflicts: # src/components/tile-manager/themes/tile-manager.base.scss # src/components/tile-manager/themes/tile.base.scss # src/components/tile-manager/tile.ts
feat(tile-manager): implement base resizing logic
…om/IgniteUI/igniteui-webcomponents into mtsvyatkova/feat-1379-tile-manager # Conflicts: # stories/tile-manager.stories.ts
…om/IgniteUI/igniteui-webcomponents into mtsvyatkova/feat-1379-tile-manager
This is a PoC but we can evaluate if this is something we want and design UX around it.
Cleaned-up some code. Initial tests for drag and drop behavior.
Fixed an issue with fullscreen event handler when the tile manager and its tiles are in a Shadow DOM region.
Exposed a new internal resize container component and controller. Improved the resize behavior of the tile manager: deferred resizing with snapping based on the configuration of the tile manager grid and its tiles. Improved UX by introducing view transitions when resizing tiles in the tile manager. --------- Co-authored-by: onlyexeption <[email protected]>
* Emulate native drag and drop using PointerEvent API providing touch-based drag and drop behavior. * Improved the deferred drag operations for tiles by moving the drag ghost into a separate layer, simplifying some internal implementation logic. * Use view transitions for drag operations for better UX. * Added a dragMode property to control if and how drag operations are done in the tile manager. * Added a resizeMode property to control if and how resize operations are done in the tile manager. --------- Co-authored-by: Radoslav Karaivanov <[email protected]>
Resize indicators bug
Result: The indicators get selected and look very odd. Hover over another tile and then back to the second one. The indicators are still like that. |
…om/IgniteUI/igniteui-webcomponents into mtsvyatkova/feat-1379-tile-manager
…om/IgniteUI/igniteui-webcomponents into mtsvyatkova/feat-1379-tile-manager
Abstracted cancel logic for both behaviors to be independent from focus state Added tests for drag behavior controller
…om/IgniteUI/igniteui-webcomponents into mtsvyatkova/feat-1379-tile-manager
Fixed DOM structure unit test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.