Migrate eslint configuration, Fix formatting-check

Author: errfrom

.eslintrc.json

@@ -79,7 +79,7 @@ check-format: check-explicit-exports check-examples-imports check-whitespace
 	@purs-tidy check ${ps-sources}
 	@nixpkgs-fmt --check ${nix-sources}
 	@prettier --log-level warn -c ${js-sources}
-	@eslint --quiet ${js-sources} --parser-options 'sourceType: module'
+	@eslint --quiet ${js-sources}
 
 format:
 	@purs-tidy format-in-place ${ps-sources}

Makefile

@@ -0,0 +1,33 @@
+import js from "@eslint/js";
+import globals from "globals";
+
+export default [
+  js.configs.recommended,
+  {
+    languageOptions: {
+      globals: {
+        ...globals.browser,
+        ...globals.commonjs,
+        ...globals.es2021,
+        ...globals.node
+      },
+
+      ecmaVersion: "latest",
+      sourceType: "module"
+    },
+
+    rules: {
+      "no-var": 2,
+      "no-case-declarations": 0,
+
+      "no-unused-vars": [
+        "error",
+        {
+          argsIgnorePattern: "^_",
+          caughtErrorsIgnorePattern: "^_",
+          vars: "local"
+        }
+      ]
+    }
+  }
+];

eslint.config.js

@@ -243,6 +243,8 @@
 
           devShell = project.devShell;
 
+          nodeModules = project.nodeModules;
+
           apps = {
             # TODO: restore this
             # https://github.com/Plutonomicon/cardano-transaction-lib/issues/1578
@@ -364,9 +366,9 @@
       checks = perSystem (system:
         let
           pkgs = nixpkgsFor system;
-
+          psProject = psProjectFor pkgs;
         in
-        (psProjectFor pkgs).checks
+        psProject.checks
         // {
           formatting-check = pkgs.runCommand "formatting-check"
             {
@@ -379,7 +381,10 @@
               ];
             }
             ''
-              cd ${self}
+              cd $TMPDIR
+              ln -sfn ${psProject.nodeModules}/lib/node_modules node_modules
+              cp -r ${self}/* .
+
               make check-format
               touch $out
             '';

flake.nix

@@ -50,13 +50,15 @@
     "xhr2": "0.2.1"
   },
   "devDependencies": {
+    "@eslint/js": "^9.7.0",
     "blakejs": "1.2.1",
-    "jssha": "3.2.0",
     "buffer": "6.0.3",
     "doctoc": "^2.2.1",
     "esbuild": "0.18.11",
     "esbuild-plugin-polyfill-node": "^0.3.0",
     "esbuild-plugin-wasm": "^1.1.0",
+    "globals": "^15.8.0",
+    "jssha": "3.2.0",
     "node-polyfill-webpack-plugin": "2.0.1",
     "webpack": "5.88.1",
     "webpack-cli": "5.1.4",

package-lock.json

@@ -6,7 +6,7 @@ files="
 *.md
 *.nix
 *.dhall
-.eslintrc.json
+eslint.config.js
 .mlc_config.json
 .tidyrc.json
 LICENSE