Ticket sending #127
Merged
Ticket sending #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lugrim
reviewed
Jan 25, 2024
KwikKill
force-pushed
the
ticket-sending
branch
from
186d8a3 to
4c5965a
Compare
Lugrim
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR :
/get/{username}/{token}to/get/{id}/{token}The ticket generation use reportlab. This is pretty hard to maintains imo but no serious alternatives were available. I tried a bunch of tools to convert html to pdf so we could had only a html template but they were all not supporting CSS3 or based on webdrivers hard to maintains.