Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve block category mask performance #3148

Merged
merged 1 commit into from
Mar 23, 2025
Merged

Improve block category mask performance #3148

merged 1 commit into from
Mar 23, 2025

Conversation

SirYwell
Copy link
Member

Overview

Description

The test(BV3) method already uses it this way. It performs around 10x better in the test method itself, though overall speedup is rather 1.5x-2x.

Submitter Checklist

  • Make sure you are opening from a topic branch (/feature/fix/docs/ branch (right side)) and not your main branch.
  • Ensure that the pull request title represents the desired changelog entry.
  • New public fields and methods are annotated with @since TODO.
  • I read and followed the contribution guidelines.

@SirYwell SirYwell requested a review from a team as a code owner March 15, 2025 15:34
@SirYwell SirYwell changed the title Improve block category mask Improve block category mask performance Mar 17, 2025
@dordsor21 dordsor21 requested a review from a team March 21, 2025 12:15
@SirYwell SirYwell merged commit 8c003c2 into main Mar 23, 2025
9 checks passed
@SirYwell SirYwell deleted the perf/category-mask branch March 23, 2025 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dordsor21 dordsor21 dordsor21 approved these changes

@NotMyFault NotMyFault NotMyFault approved these changes

Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SirYwell @dordsor21 @NotMyFault