Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enh(docker): add some tools to the image #1958

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

TPXP
Copy link

@TPXP TPXP commented Mar 18, 2025

Description

This adds the following packages to the docker image, useful for debugging

  • grep: output filtering
  • less: pager used by the psql command (it shows error sh: line 1: less: command not found without it if output has more than a few lines - for example when listing tables with \d+)

Checklist

  • Commit sequence broadly makes sense
  • Commits have useful messages
  • New tests are added if needed and existing tests are updated
  • Any changes are noted in the changelog
  • Code is formatted with fourmolu on version 0.10.1.0 (which can be run with scripts/fourmolize.sh)
  • Self-reviewed the diff

Migrations

No breaking change

This adds the following packages to the docker image, useful for debugging
* `grep`: output filtering
* `less`: pager used by the `psql` command (it shows error `sh: line 1: less: command not found` without it if output has more than a few lines - for example when listing tables with `\d+`)
@TPXP TPXP requested a review from a team as a code owner March 18, 2025 13:37
Copy link
Contributor

@sgillespie sgillespie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. You can also always connect via some other container. You might want to check out: https://github.com/dbcli/pgcli. Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants