Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't use $ as a prefix in derived #308

Merged
merged 1 commit into from
Nov 27, 2023
Merged

Conversation

gdamjan
Copy link
Contributor

@gdamjan gdamjan commented Nov 12, 2023

The svelte 5 compiler was complaining about the use of the $ in the variable names:

[vite-plugin-svelte] /home/damjan/projects/irclogs/svelte/node_modules/.pnpm/[email protected]/node_modules/svelte-spa-router/Router.svelte:77:5 The $ prefix is reserved, and cannot be used for variables and imports
file: /home/damjan/projects/irclogs/svelte/node_modules/.pnpm/[email protected]/node_modules/svelte-spa-router/Router.svelte:77:5
error during build:
CompileError: The $ prefix is reserved, and cannot be used for variables and imports

I choose _loc for now, just to see it working. Suggestions welcome.

```
[vite-plugin-svelte] /home/damjan/projects/irclogs/svelte/node_modules/.pnpm/[email protected]/node_modules/svelte-spa-router/Router.svelte:77:5 The $ prefix is reserved, and cannot be used for variables and imports
file: /home/damjan/projects/irclogs/svelte/node_modules/.pnpm/[email protected]/node_modules/svelte-spa-router/Router.svelte:77:5
error during build:
CompileError: The $ prefix is reserved, and cannot be used for variables and imports
```
@ItalyPaleAle
Copy link
Owner

Thanks for this!

@ItalyPaleAle ItalyPaleAle merged commit f525f9d into ItalyPaleAle:master Nov 27, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants