geekha/fix-hero-remove-pointer-events #13
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add sizes props to reuse in hero and footer
change design footer and implement in home page
|
Hola @geekhadev 👋 Gracias por el PR (esto fue mi error por algo con respecto a Windows, entonces doble gracias). A pesar de que la descripción está bien y el commit está bien, si te fijas este PR está dependiendo del otro PR (ya que incluye esos 3 commits de #12 Lo ideal es que los PRs no contengan commits de otros PRs. Si corriges esto podemos mergear sin problema. |
|
Tienes razón error mío hice la rama partiendo de la rama del otro PR, déjame lo vuelvo a hacer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Se agrega la clase
pointer-events-nonea undiven la zona del hero que estáabsolutey bloquea el funcionamiento esperado del puntero sobre el texto.Ver issue #11