Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make input vendor and product fields optional #58

Merged
merged 2 commits into from
Nov 11, 2024

Conversation

FortStatement
Copy link

get_inputs calls started failing on my machine because wlr_virtual_keyboard_v1 doesn't have vendor or product fields (cargo test fails as well). swaymsg treats these as optional in practice and uses 0 by default for the values.

@JayceFayne
Copy link
Owner

JayceFayne commented Nov 10, 2024

Looking at sways ipc code it seems like these fields are only set for libinput devices. Like the libinput field itself these should indeed be optional. Can you pls group them together and add a doc comment for the vendor and product fields?

@JayceFayne
Copy link
Owner

Thanks!

@JayceFayne JayceFayne merged commit 021f3d6 into JayceFayne:master Nov 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants