Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functions to calculate Precision, Recall and F1score. #255

Merged
merged 3 commits into from
Jan 28, 2025

Conversation

Afreen-Kazi-1
Copy link
Contributor

Add functions to calculate Precision, Recall and F1Score under the ConfusionMatrix class in detectionmetrics/utils/metrics.py.
Addresses #240 Add new metrics.

@dpascualhe
Copy link
Collaborator

Thanks for your contribution! 😄

It's looking good but I haven't tested it yet. A suggestion, could you return the results per class and global as it is done for accuracy or IoU?

@dpascualhe dpascualhe self-assigned this Jan 17, 2025
@Afreen-Kazi-1
Copy link
Contributor Author

Yes, I'll do that and update soon.

Copy link
Collaborator

@dpascualhe dpascualhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code structure is fine, but there are some errors that need to be amended.

  • Minor fixes in return statements type definitions.

Keep it up! We're almost there 😉

@dpascualhe dpascualhe merged commit ff17143 into JdeRobot:master Jan 28, 2025
@Afreen-Kazi-1
Copy link
Contributor Author

Thankyou! Is there anything more I can contribute to? I'll be glad to.

@dpascualhe
Copy link
Collaborator

Hi, sure thing! Some suggestions:

  • Try out our new notebook tutorial: tutorial_image_segmentation.ipynb. AFAIK it hasn't been tested out by any user yet and it would be great if we could have some feedback in that regard.
  • Add tests for the metrics module using pytest ( as part of Add tests #239 ).
  • Take a look at other issues in the repo for which help is wanted.

@Afreen-Kazi-1
Copy link
Contributor Author

Afreen-Kazi-1 commented Feb 20, 2025

Hi, sure thing! Some suggestions:

  • Try out our new notebook tutorial: tutorial_image_segmentation.ipynb. AFAIK it hasn't been tested out by any user yet and it would be great if we could have some feedback in that regard.*

Sure, I'll test this out and update soon. Should it be a new issue though?

  • Add tests for the metrics module using pytest ( as part of Add tests #239 ).

I think a couple of contributors have been assigned to this and their approaches are at par. If you think there's something more I can add there, then please let me know.

  • Take a look at other issues in the repo for which help is wanted.

Sure, definitely!

@dpascualhe
Copy link
Collaborator

dpascualhe commented Feb 25, 2025

Sure, I'll test this out and update soon. Should it be a new issue though?

Not the testing itself, but feel free to open up any issue you find during the process 😄

I think a couple of contributors have been assigned to this and their approaches are at par. If you think there's something more I can add there, then please let me know.

For now let's wait to see if the people that have expressed their interest make their contribution. I'll let you know if we need help in that regard.

Overall, I would prioritize testing the current tutorial available to get a better sense of whether it is usable as it is now and maybe we can work together in building new tutorials (#245 ).

Once again, thanks for your interest!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants