feat: EXPOSED-729 [Oracle] Allow setting limit with DELETE #2403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is currently only possibe to set a limit on update() even though the same ROWNUM syntax that is used for that function provider also applies to delete(). This logic has now been shared across both and tests adjusted.
e5l
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary of the change: Using
Table.delete(limit = #)with Oracle no longer throws unsupported exception.Detailed description:
Oracle does not support the
LIMITsyntax, but it is still possibly to limit the number of rows on which an update or delete operation takes place. This can be done using theROWNUMpseudocolumn, which is the current implementation forTable.update(limit = #). For some reason, this syntax was never extended toDELETE.delete()instead of throwingType of Change
Please mark the relevant options with an "X":
Affected databases:
Checklist
Related Issues
EXPOSED-729