refactor: EXPOSED-730 Extract TransactionManager companion methods from core module #2405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e5l
approved these changes
Feb 12, 2025
| @@ -230,7 +230,7 @@ abstract class AbstractQuery<T : AbstractQuery<T>>( | |||
| } | |||
| if (set.source != Table.Dual || currentDialect.supportsDualTableConcept) { | |||
| append(" FROM ") | |||
| set.source.describe(TransactionManager.current(), this) | |||
| set.source.describe(CoreManager.currentTransaction(), this) | |||
There was a problem hiding this comment.
I would be more specific and and use CoreTransactionManager name
| import java.util.concurrent.ConcurrentLinkedDeque | ||
| import java.util.concurrent.atomic.AtomicReference | ||
|
|
||
| private object NotInitializedManager : TransactionManagerApi { |
There was a problem hiding this comment.
same applied to the naming in other places
bog-walk
force-pushed
the
bog-walk/split-transaction-manager
branch
from
1215a7e to
74f4e06
Compare
bog-walk
force-pushed
the
r2dbc-poc-2
branch
from
e5e5afe to
cdd9dab
Compare
…om core module As part of the R2DBC implementation: - Remove companion object from original interface and rename to TransactionManagerApi - Create new object CoreManager that stores members responsible for internal processing of databases and their associated managers - Mark this as @internalapi - Rename both module managers to TransactionManager & add their own companion objects that rely on CoreManager - Remove useless casts from everywhere - Move transaction properties out of core so that there is no need to define a core TM
…om core module - Remove strange import optimization results - Return original ThreadLocalTransactionManager into jdbc module with deprecation flag - Refactor Database.connect() variants to account for existing deprecated class
…om core module - Rename new object to CoreTransactionManager - Rename private object to NotInitializedTransactionManager
bog-walk
force-pushed
the
bog-walk/split-transaction-manager
branch
from
74f4e06 to
24978aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is meant only for merge into R2DBC branch
r2dbc-poc-2❗Note about the diff size ❗
Description
Summary of the change:
exposed-jdbcandexposed-r2dbcnow have their ownTransactionManagerwith companion object methods, which rely on stored data in common fields found in newexposed-core/CoreManagerobject.Detailed description:
Current setup has common
TransactionManagerinterface in core module, which uses itscompanion objectto store and process internal data about registered databases and their associated managers. This means that the JDBC and R2DBC implementations would need to always cast when calls likeTransactionManager.current()are made.TransactionManagerinterface and rename the latter toTransactionManagerApi.CoreManagerto keep all original content from above.currentTransaction(),currentTransactionOrNull.TransactionManager...inexposed-corewithCoreManager....@InternalApibuild.gradle.ktsto avoid annotating every use ofCoreManagerin core moduleTransactionManagerso API hasn't changed much & add their own companion objects that rely onCoreManagerdataThreadLocalTransactionManagertoexposed-jdbcwith Deprecation annotation.managerparameter inDatabase.connect()variants to account for existing deprecated class.Type of Change
Please mark the relevant options with an "X":
Affected databases:
Checklist
Related Issues
EXPOSED-730