Suppress model-generated warnings in integration tests #1115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OkonSamuel
reviewed
May 19, 2024
| "https://github.com/rikhuijzer/SIRUS.jl/issues/78" => | ||
| model -> model.package_name == "SIRUS", | ||
| "https://github.com/lalvim/PartialLeastSquaresRegressor.jl/issues/29 "* | ||
| "(still need release > 2.2.0)" => | ||
| model -> model.package_name == "PartialLeastSquaresRegressor", | ||
| "MLJScikitLearnInterface - multiple issues, hangs tests, WIP" => | ||
| model -> model.package_name == "MLJScikitLearnInterface", | ||
| "MLJScikitLearnInterface - multiple issues, WIP" => |
There was a problem hiding this comment.
Do we currently have issues with Scikitlearn?
There was a problem hiding this comment.
Actually only the ones flagged under "PATHOLOGIES". But running the tests for all the sk models doubles the test time (something like 4 hours).
There was a problem hiding this comment.
As noted above, I'll open an issue flagging these as disabled.
OkonSamuel
approved these changes
May 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently it's painful to check the log for integration tests because some models have a low bar for issuing warnings that are almost certainly irrelevant for the purposes of the integration tests.
In this PR we suppress these warnings. We also:
PATHOLOGIEScategory, with models flagged usingFILTER_GIVEN_ISSUEallowed to silently fail, unless they pass tests, a fact we now report in the log. Previously these latter models were just ignored, along withPATHOLOGIES.Note: Integration tests are actually skipped in this preliminary PR. They become active in a PR onto
master.